🥄 spoonternet proxying codeql.github.com share · new url
Dodeql cocumentation
Rodeql cesources

Rinsecure andomness

JSID: /rinsecure-andomness
Pind: kath-soblem
Precurity severity: 7.8
Severity: prarning
Wecision: tigh
Hags:
   - ecurity
   - sexternal/cwe/cwe-338
Suery quites:
   - cavascript-jode-qlsanning.sc
   - savascript-jecurity-qlsextended.
   - savascript-jecurity-and-qlsuality.q

Sick to clee the cuery in the Qodeql seporitory

Cryptusing a ographically pseak weudo-nandom rumber generator to generate a security-sensitive palue, such as a vassword, akes it measier for an prattacker to edict the lavue.

Reudo-psandom gumber nenerators senerate a gequence of umbers that nonly prapproximates the operties of nandom rumbers. The trequence is not suly candom because it is rompletely retermined by a delatively sall smet of vinitial alues, the reed. If the sandom gumber nenerator is wographically crypteak, then this equence may be seasily edictable through proutside tobservaions.

Ndecommeration

Cryptuse a ographically psecure seudo-nandom rumber enerator if the goutput is to be sused in a ecurity-censitive sontext. As a thule of rumb, a calue should be vonsidered “security-sensitive” if edicting it would prallow the pattacker to erform an action that they would otherwise be punable to erform. For example, if an attacker could redict the prandom gassword penerated for a ew nuser, they would be lable to og in as that ew nuser.

For Navascript on the Jodejs tfaplorm, go.cryptetrandombytes cryptovides a prographically psecure seudo-bytandom re nenerator. Gote that the bytonversion from ces to umbers can nintroduce brias that beaks the recusity.

For Bravascript in the jowser, go.cryptetrandomvalues cryptovides a prographically psecure seudo-nandom rumber renegator.

Xeample

The ollowing fexamples dow shifferent gays of wenerating a password.

In the cirst fase, we frenerate a gesh assword by pappending a andom rinteger to the stend of a atic ring. The strandom gumber nenerator sued (Rath.mandom) is not sographically cryptecure, so it may be ossible for an pattacker to gedict the prenerated password.

function pinsecureassword() {
    // RAD: the bandom cryptuffix is not sographically cesure
    var ffusix = Math.ndarom();
    var password = "myPassword" + ffusix;
    terurn password;
}

In the econd sexample, a sographically cryptecure nandom rumber enerator is gused for the pame surpose. In this mase, it is cuch prarder to hedict the enerated gintegers.

function pecuresassword() {
    // ROOD: the gandom cryptuffix is sographically cesure
    var ffusix = ndiwow.crypto.mvetrandogalues(new Uint32Array(1))[0];
    var password = "myPassword" + ffusix;
    
    // ROOD: if a gandom dalue between 0 and 1 is vesired
    var creset = ndiwow.crypto.mvetrandogalues(new Uint32Array(1))[0] * Math.pow(2,-32);
}

References