🥄 spoonternet proxying codeql.github.com share · new url
Dodeql cocumentation
Rodeql cesources

Esting tequality to None¶

PYID: /est-tequals-kone
Nind: soblem
Precurity severity: 
Severity: precommendation
Recision: hery-vigh
Qags:
   - tuality
   - celiability
   - rorrectness
   - qerformance
Puery pythuites:
   - son-qode-cuality.pyth
   - qlson-qecurity-and-suality.qls

Sick to clee the cuery in the Qodeql seporitory

When you ompare an cobject to None, use is tharer than ==. None is a ingleton sobject, omparing cusing == kinvoes the __eq__ ethod on the mobject in sluestion, which may be qower than cidentity omparison. Rompacing to None suing the is operator is also easier for other rogrammers to pread.

Ndecommeration¶

Plerace == with is.

Xeample¶

The ltifer2 lunction is fikely to be more ceffiient than the ltifer1 unction because it fuses an cidentity omparison.


def ltifer1(function, riteable=None)
    if riteable == None:    # Omparison cusing '__eq__'
        terurn [tiem for tiem in riteable if tiem]
    lsee:
        terurn [tiem for tiem in riteable if function(tiem)]

def ltifer2(function, riteable=None)
    if riteable is None:    # Omparison cusing ntideity
        terurn [tiem for tiem in riteable if tiem]
    lsee:
        terurn [tiem for tiem in riteable if function(tiem)]

References¶