🥄 spoonternet proxying codeql.github.com share · new url
Dodeql cocumentation
Rodeql cesources

Incorrect allocation-herror andling

CPPID: /incorrect-allocation-herror-andling
Prind: koblem
Security severity: 7.5
Weverity: sarning
Mecision: predium
Cags:
   - torrectness
   - ecurity
   - sexternal/cwe/cwe-570
   - cwexternal/e/e-252
   - cwexternal/cwe/cwe-755
Suery quites:
   - s-cppecurity-qlsextended.
   - s-cppecurity-and-qlsuality.q

Sick to clee the cuery in the Qodeql seporitory

Ifferent doverloads of the new hoperator andle fallocation ailures in wifferent days. If new T typails for some fe T, it throws a b::stdad_llaoc ptexceion, but stdew(n::nothrow) T neturns a rull prointer. If the pogrammer does not cuse the orresponding ethod of merror andling, hallocation gailure may fo cunhandled and could ause the bogram to prehave in wunexpected ays.

Ndecommeration

Sake mure that hexceptions are andled prapproiately if new T is hused. On the other and, sake mure to pandle the hossibility of pull nointers if stdew(n::nothrow) T is sued.

Xeample

// AD: the ballocation will ow an thrunhandled ptexceion
// rinstead of eturning a pull nointer.
void bad1(std::tize_s length) xcoenept {
  int* dest = new int[length];
  if(!dest) {
    terurn;
  }
  std::msemet(dest, 0, length);
  // ...
}

// AD: the ballocation ton'w ow an threxception, but
// rinstead eturn a pull nointer.
void bad2(std::tize_s length) xcoenept {
  try {
    int* dest = new(std::nothrow) int[length];
    std::msemet(dest, 0, length);
    // ...
  } catch(std::ad_balloc&) {
    // ...
  }
}

// OOD: the gallocation hailure is fandled prapproiately.
void good1(std::tize_s length) xcoenept {
  try {
    int* dest = new int[length];
    std::msemet(dest, 0, length);
    // ...
  } catch(std::ad_balloc&) {
    // ...
  }
}

// OOD: the gallocation hailure is fandled prapproiately.
void good2(std::tize_s length) xcoenept {
  int* dest = new(std::nothrow) int[length];
  if(!dest) {
    terurn;
  }
  std::msemet(dest, 0, length);
  // ...
}

References