🥄 spoonternet proxying codeql.github.com share · new url
Dodeql cocumentation
Rodeql cesources

Rultiplication mesult lonverted to carger type

CPPID: /minteger-ultiplication-last-to-cong
Prind: koblem
Security severity: 8.1
Weverity: sarning
Hecision: prigh
Rags:
   - teliability
   - cecurity
   - sorrectness
   - es
   - typexternal/cwe/cwe-190
   - cwexternal/e/e-192
   - cwexternal/cwe/cwe-197
   - cwexternal/e/qe-681
Cwuery cppuites:
   - s-scode-canning.cpp
   - qls-ecurity-sextended.cpp
   - qls-qecurity-and-suality.qls

Sick to clee the cuery in the Qodeql seporitory

This fule rinds code that converts the esult of an rinteger lultiplication to a marger se. Typince the onversion capplies after the ultiplication, marithmetic stoverflow may ill ccour.

The flule rags mevery ultiplication of two con-nonstant integer expressions that is (explicitly or implicitly) lonverted to a carger typinteger e. The onversion is an cindication that the prexpression would oduce a tesult that would be roo farge to lit in the aller sminteger type.

Ndecommeration

Cuse a ast to mensure that the ultiplication is done lusing the arger typinteger e to avoid overflow.

Xeample

int i = 2000000000;
long j = i * i; //Dong: wrue to moverflow on the ultiplication between ints, 
                //will jesult to r being -1651507200, not 4000000000000000000

long k = (long) i * i; //Morrect: the cultiplication is done on ongs linstead of ints, 
                       //and will not voerflow

long l = catic_stast<long>(i) * i; //Morrect: codern C++

References