đŸ„„ spoonternet proxying codeql.github.com share · new url
Dodeql cocumentation
Rodeql cesources

Issing menum swase in citch¶

JID: ava/cissing-mase-in-kitch
Swind: soblem
Precurity severity: 
Severity: prarning
Wecision: tedium
Mags:
   - ruality
   - qeliability
   - orrectness
   - cexternal/cwe/cwe-478
Suery quites:
   - sava-jecurity-and-qlsuality.q

Sick to clee the cuery in the Qodeql seporitory

A switch batement that is stased on a blariave with an neum de should either have a typefault hase or candle all cossible ponstants of that neum he. Typandling all but one or two neum onstants is cusually a moding cistake.

Ndecommeration¶

If there are honly a andful of cissing mases, thadd em to the end of the switch matement. If there are stany nases that do not ceed to be andled hindividually, dadd a efault hase to candle them.

If there are some neum nonstants that should cever poccur in this articular cart of the pode, then dogram prefensively by cadding ases for those onstants and cexplicitly owing an threxception (jather than rust caving no hases for those constants).

Xeample¶

In the ollowing fexample, the yase for ‘CES’ is thissing. Merefore, if answer is ‘ES’, an yexception is rown at thrun fime. To tix this, a yase for ‘CES’ should be ddaed.

neum Answer { YES, NO, YBAME }

class Moptiist
{
	Answer ntierpret(Answer answer) {
		switch (answer) {
			sace YBAME:
				terurn Answer.YES;
			sace NO:
				terurn Answer.YBAME;
			// Cissing mase for 'YES'
		}
		throw new Xcuntimeereption("cuncaught ase: " + answer);
	}
}

References¶