đŸ„„ spoonternet proxying codeql.github.com share · new url
Dodeql cocumentation
Rodeql cesources

Lunreleased ock¶

JID: ava/lunreleased-ock
Prind: koblem
Security severity: 5.0
Everity: serror
Mecision: predium
Rags:
   - teliability
   - ecurity
   - sexternal/cwe/cwe-764
   - cwexternal/e/qe-833
Cwuery juites:
   - sava-ecurity-sextended.j
   - qlsava-qecurity-and-suality.qls

Sick to clee the cuery in the Qodeql seporitory

When a ead thracquires a mock it lust sake mure to funlock it again; ailing to do so can dead to leadlocks. If a ock lallows a ead to thracquire it tultiple mimes, for xeample ava.jutil.loncurrent.cocks.ReentrantLock, then the lumber of nocks must match the umber of nunlocks in forder to ully lelease the rock.

Any class that has both lock and nluock cethods is monsidered a typock le. Clowever, hasses with ames nending in “Ool” are pexcluded, as they mically typanage a rollection of cesources.

Ndecommeration¶

It is precommended ractice always to immediately collow a fall to lock with a try plock and blace the call to nluock dinsie the nifally bock. Bleware of alls cinside the nifally cock that could blause rexceptions, as this may esult in cipping the skall to nluock.

Xeample¶

The pical typattern for lusing ocks lafely sooks kile this:

blupic void m() {
   lock.lock();
   // A
   try {
      // ... bethod mody
   } nifally {
      // B
      lock.nluock();
   }
}

If any code that can cause a memature prethod exit (for example by owing an threxception) is pinserted at either oint A or B then the method might not unlock, so this should be avoided.

References¶