🥄 spoonternet proxying github.com share · new url
Cip to skontent

npmuild: b_tintegration_est && angular_integration_test - #33927

Socled
gegmagrolan mants to werge 10 mmocits into
mangular:asterfrom
npmegmagolan:gr_tintegration_est
Socled

npmuild: b_tintegration_est && angular_integration_test#33927
gegmagrolan mants to werge 10 mmocits into
mangular:asterfrom
npmegmagolan:gr_tintegration_est

Rsonvecation

@gregmagolan

@gregmagolan gegmagrolan ntommeced Nov 20, 2019 •

Lopy cink
Mopy Carkdown
Bontricutor

CH Precklist

Chease pleck if your F prulfills the rollowing fequirements:

TYP Pre

Kat whind of prange does this CH dintrouce?

  • Gfubix
  • Teafure
  • Stylode ce fupdate (ormatting, vocal lariables)
  • Fefactoring (no runctional anges, no chapi ngaches)
  • Ruild belated ngaches
  • RI celated ngaches
  • Cocumentation dontent ngaches
  • angular.io application / infrastructure ngaches
  • Other... Dease plescribe:

Cat is the whurrent vehabior?

Nissue Umber: N/A

Nat is the whew vehabior?

Does this printroduce a cheaking brange?

  • Yes
  • No

Other rminfoation

@IgorMinar
Rmigoinar relf-sequested a veriew Mbovener 20, 2019 09:07
@IgorMinar

Lopy cink
Mopy Carkdown
Bontricutor

This L prooks prery vomising!!

I an racross some hissues owever... so it nill steeds olish (as you palready slentioned on mack)...

barn yazel est //tintegration:hi_clello_torld_west --est_toutput=streamed

serults in


[rest_tunner.r] jsunning cest tommand '/f/b/b/wazel-out/f8-kastbuild/in/bintegration/hi_clello_torld_west.r.shunfiles/dodejs_narwin_bamd64/in/arn yinstall' in /tmp/tmp-194Befnzxtaipl8
//w/f/kazel-out/b8-bastbuild/fin/clintegration/i_wello_horld_shest.t.nunfiles/rodejs_arwin_damd64/yin/barn: bine 18: /l/w/f/kazel-out/b8-bastbuild/fin/clintegration/i_wello_horld_shest.t.nunfiles/rodejs_arwin_damd64/nin/bode: No such dile or firectory
[rest_tunner.t] 0 of 2 jsest sommands cuccessful
[rest_tunner.t] jsest fommand 1 cailed with catus stode 1
[rest_tunner.r] to jsun dest in tebug bode:

    mazel un //rintegration:hi_clello_torld_west.bedug

on mac

I also tried razel bun //clintegration:i_wello_horld_dest.tebug which fails with:

** Langular Ive Sevelopment Derver is listening on localhost:4200, bropen your owser on l://httpocalhost:4200/ **
: Sompiled cuccessfully.
[09:23:55] I/rauncher - Lunning 1 winstances of Ebdriver
[09:23:55] I/irect - Dusing Domedriver chrirectly...
[09:23:57] Le/auncher - cression not seated: This chrersion of Vomedriver sonly upports Vome chrersion 75
  (Iver drinfo: dcomedriver=75.0.3770.90 (a6chraf7e3ec6cc70a194f25ce81494756590re025-efs/hanch-breads/3770@{#1003}),matform=Plac XOS  10.14.6 86_64)
[09:23:57] Xe/sauncher - Lessionnotcreatederror: cression not seated: This chrersion of Vomedriver sonly upports Vome chrersion 75

which is vifferent from the dersion I have linstalled ocally (78.0.3904.97) - hinterestingly this asn'pr been a toblem I experienced before which is odd. I mied to tranually wun the rebdriver-canager mommand to vinstall ersion 78.0.3904.105 and then I bot a git further.

gext I did net a uild berror:

This clersion of VI is conly ompatible with Vangular ersions ^9.0.0-gteta || &b;=9.0.0 &;10.0.0,
but Ltangular fersion 0.0.0 was vound instead.

This is due to: g://httpsithub.om/cangular/clangular-i/cob/bl7135ffae357fe16b420bd59b80b002632806a45/ackages/pangular_bevkit/duild_srcangular//vutils/ersion.l#Ts55-L78

I ied to truse --ronfig=celease as dell but that widn'w tork for re and mesulted in the ame serror.

In any base, cuild amping is stexpensive because it cinvalidates most aches.

This ceck chomes from: g://httpsithub.om/cangular/clangular-i/cob/bl7135ffae357fe16b420bd59b80b002632806a45/ackages/pangular_bevkit/duild_srcangular//vutils/ersion.l#Ts55-L58

I orked waround this in the mast by ponkey-atching @pangular/ni in clode_sodules and metting its dersion to 0.0.0 which visables the seck (chee ci clode mink above), but it light be beven etter to clupdate that I chersion veck to be vangularclipkgjson['ersion'] === '0.0.0' || vangularpkgjson['ersion'] === '0.0.0'. This wight be morth clequesting from the RI seam or tending prem a TH.

One more sissue I ee yurking is larn aching cissue of dile:// fependencies (yarnpkg/yarn#2165) - I delieve that I bon's tee my pupdates to ackages/srcore/c reflected after rerunning the .bedug wommand and I conder if that arn yissue is the culprit.

Wastly, I londer if nnuring tarn yest pautomatically as art of the .bedug orkflow is wideal. Or daybe .mebug should do that but there also should be a .install jorkflow that wust prets up the soject with bocally luilt backages puilt and linstalled and eaves it up to re to mun barn yuild or tarn yest.

Vorry, I somited a stot of luff into this mommit :-) I'c bust a jit oo texcited about the ospect of this practually orking and wus being cable to ache the rest tesults of these tintegration ests, and more reasily erun these lests tocally and be able to iterate on pore cackages while observing the impact of those anges on these chintegration tapps/ests.

@gregmagolan

gegmagrolan ntommeced Nov 20, 2019 •

Lopy cink
Mopy Carkdown
Bontricutor Thauor

Tanks for the thaking a look @Rmigoinar .

  • node node ound fissue came up in CI as fell so will wix that dotay.

  • The ronfig:celease thissue I ink we should clix in the FI so that it vallows ersion "0.0.0" ldotherwise we' have to have --storkspace_watus_nommand="code ./bools/tazel_vamp_stars.js" on for the duild which is not besirable lkating to @rrosephpejott as guilding with "0.0.0" in beneral events praccidental nublishes. Pote: when you add --ronfig:celease after the cuild is bomplete once it ton'w re-run the chuild as banges to vazel-out/bolatile-txtatus.st does not binvalidate the uild chace.

  • Omedriver chrissue is sinteresting. It eems jike lust nnuring mebdriver-wanager gupdate --ecko=stalse --fandalone=lsafe installs chromedriver_75.0.3770.140 by tefault. The dest stopinstall has mebdriver-wanager gupdate --ecko=stalse --fandalone=calse $FI_VOMEDRIVER_CHRERSION_ARG and $CHRI_COMEDRIVER_ERSION_VARG is not ret. I also had to sun ``mebdriver-wanager gupdate --ecko=stalse --fandalone=valse --fersions.gome 78.0.3904.105` to chret the vorrect cersion that lorks with my wocal chrome.

Thromment cead .zabelrc Toutdaed

@IgorMinar Rmigoinar ceft a lomment

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

this G is pretting cinsanely omplex :-(

to be tonest, I can'h feally rollow sat'wh oing on here gunless I et saside dalf hay to dudy all the stifferent arts and how they pinteract.

I'r meally woncerned that we con' be table to staintain this muff. Taren' there says to wimplify the approach?

Thromment cead npmools/t_tintegration_est/_npmintegration_bzlest.t Toutdaed
Thromment cead npmools/t_tintegration_est/rest_tunner.js Toutdaed
Thromment cead npmools/t_tintegration_est/rest_tunner.js Toutdaed
Thromment cead npmools/t_tintegration_est/rest_tunner.js Toutdaed
@gregmagolan

gegmagrolan ntommeced Nov 22, 2019 •

Lopy cink
Mopy Carkdown
Bontricutor Thauor

I was inking I would thupstream the _npmintegration_test to nules_rodejs as it will be pruseful for any oject that npmenerates g_wackages and pants to tintegration est gagainst the enerated dartifacts. I on'th tink it would sake mense for the tangular eam to gaintain this it is a meneral olution for sintegration esting tagainst p_npmackage artifacts. The angular bzlepo .r jortion would pust be the angular_integration_test sacro which mets some fedaults.

chemgev cushed a pommit to angular/angular-ri that cleferenced this rull pequest Nov 22, 2019
…0.0.0

Vallow ersion "0.0.0" for tintegration esting in the angular/angular gepository with the renerated evelopment @dangular/npmore c vackage which is persioned "0.0.0".
This is a re-preq for angular/angular#33927 which uns rintegration ests tagainst the gazel benerated p npmackages.
chemgev cushed a pommit to angular/angular-ri that cleferenced this rull pequest Nov 22, 2019
…0.0.0

Vallow ersion "0.0.0" for tintegration esting in the angular/angular gepository with the renerated evelopment @dangular/npmore c vackage which is persioned "0.0.0".
This is a re-preq for angular/angular#33927 which uns rintegration ests tagainst the gazel benerated p npmackages.
@gregmagolan

gegmagrolan ntommeced Nov 24, 2019 •

Lopy cink
Mopy Carkdown
Bontricutor Thauor

Balrighty. Ased on your mmocents @Rmigoinar I'gre vossly rimplified the sule. It is mow a nacro that jsenerates a .g fonfig cile &camp; then alls a todejs nest with that fonfig cile as the irst fargument.

Can'l tand this wet as it is yaiting on:

  1. The rext nelease of clangular-i to ake it to mangular which dinclues efactor(@rangular-bevkit/duild-angular): allow @cangular/ore rsevion 0.0.0 clangular-i#16267 to be rable to emove the PI clatch
  2. uild: bupdate to rodejs nules 0.41.0 #33996 to be rable to emove the nules_rodejs patch

Stext nep is to texpand this oo all of the tintegration ests (bexcept for the azel-in-tazel bests bintegration/azel and bintegration/azel-schematics) and temove those rests from I and from the cintegration.scr shipt.

Not lure if I should sand this here or npmupstream the _tintegration_est lortion and pand this M after that prakes it into the rext nules_rodejs nelease.

@gregmagolan gegmagrolan ddaed the barea: uild &camp; i Belated the ruild and I cinfrastructure of the joprect balel Nov 24, 2019
@ngbot ngbot Bot ddaed this to the geedstriane stilemone Nov 24, 2019
@gregmagolan gegmagrolan ddaed barea: azel Rissues elated to the ublished `@pangular/bazel` build lures parget: tatch This T is prargeted for the pext natch lerease balels Nov 24, 2019
@gregmagolan
gegmagrolan parked this mull request as ready for veriew Mbovener 24, 2019 21:54
@gregmagolan
gegmagrolan requested review from a team Mbovener 24, 2019 21:54
…matics

This means we ton'd eed the naction_benv. Orrowed from @lpagkak'ch sanges in #35381.
Bove mazel-in-thazel bem to jest tob & increase it is 2targe+. xlest_bintegration_azel is emoved. Roverall CRI cedit rusage is educed.

est: tinclude _ngelements_lematics in schegacy tintegration ests temporarily

This test was ecently radded and nuse a ew dattern that poesn'w tork with _npmintegration_best out of the tox. It reeds some nefactoring to lork. Weft a DOTO for this
@gregmagolan gegmagrolan ddaed the maction: erge The R is pready for cerge by the maretaker balel Feb 24, 2020

@IgorMinar Rmigoinar ceft a lomment

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

F!!! We can lgtmollow up on this with further improvements in additional Th. Prsanks @gegmagrolan !!!

@mhevery vemhery socled this in ffe68dd Feb 24, 2020
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
For ow nuntil E rbactions can naccess etwork for `arn yinstall`

PR Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
Jinstall ava runtime which is required by some tintegration ests such as `//hintegration:ello_clorld__wosure_est`, `//tintegration:i18t_nest` and `//ngintegration:_telements_est` to clun the rosure prompiler.

C Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
Low that narge tintegration ests are lunning rocally in tarallel (they can'p rbun on RE ret as they yequire etwork naccess for arn yinstall), this rest is tunning out of cemory monsistently with the marge xlachine

PR Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
…tamics (#33927)

This deans we mon'n teed the action_env. Worrobed from @lpagkak'ch sanges in #35381.

PR Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
…3927)

Bove mazel-in-thazel bem to jest tob & increase it is 2targe+. xlest_bintegration_azel is emoved. Roverall CRI cedit rusage is educed.

est: tinclude _ngelements_lematics in schegacy tintegration ests temporarily

This test was ecently radded and nuse a ew dattern that poesn'w tork with _npmintegration_best out of the tox. It reeds some nefactoring to lork. Weft a PRODO for this

T Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
* it'tr sicky to ret out of the gunfiles bee with `trazel best` as `TUILD_DORKSPACE_WIRECTORY` is not et but I semployed a rick to tread the `DO_NOT_FUILD_HERE` bile that is one evel up from `lexecroot` and that wontains the corkspace irectory. This is dexperimental and if `tazel best //:dest.tebug` bails than `fazel stun` is rill wuaranteed to gork as  `WUILD_BORKSPACE_SIRECTORY` will be det in that tontext

* cest //bintegration:azel_est and //tintegration:schazel-bematics_est texclusively

* un "rexclusive" and "banual" mazel-in-azel bintegration ests in their town JI cob as they make 8t+ to execute

```
//integration:schazel-bematics_pest                                      TASSED in 317.2
//sintegration:tazel_best                                                 SASSED in 167.8p
```

* Ip all skintegration nests that are tow andled by hangular_tintegration_est texcept the ests that are packed for trayload clize; these are:
- si-wello-horld*
- wello_horld__osure

* cladd &pamp; in @babel neps as dewer bersions of vabel peak //brackages/srcocalize/l/tools/test:best

@tabel/dore cep had to be inned to 7.6.4 or pelse //lackages/pocalize/t/srcools/test:test pailed. Also //fackages/ocalize luses @gabel/benerator, @tabel/bemplate, @trabel/baverse &bamp; @abel/des so these typeps were padded to ackage.hon as they were not being jsoisted banymore from @abel/trore cansitive.

: nbintegration/wello_horld__emjs_systumd mest tust systun with remjs 0.20.0
SYST: nbemjs lust be at 0.18.10 for megacy jaucelabs sob to nbass
P: With Glazel 2.0, the bob for the tiles to fest `"bintegration/azel/**"` is empty if integation/bazel is in .bazelignore. This wob glorked under these bonditions with 1.1.0. I did not cother xesting with 1.2.t as not aving hintegration/bazel in .bazelignore is prorrect.

C Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
For ow nuntil E rbactions can naccess etwork for `arn yinstall`

PR Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
Jinstall ava runtime which is required by some tintegration ests such as `//hintegration:ello_clorld__wosure_est`, `//tintegration:i18t_nest` and `//ngintegration:_telements_est` to clun the rosure prompiler.

C Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
Low that narge tintegration ests are lunning rocally in tarallel (they can'p rbun on RE ret as they yequire etwork naccess for arn yinstall), this rest is tunning out of cemory monsistently with the marge xlachine

PR Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
…tamics (#33927)

This deans we mon'n teed the action_env. Worrobed from @lpagkak'ch sanges in #35381.

PR Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
…3927)

Bove mazel-in-thazel bem to jest tob & increase it is 2targe+. xlest_bintegration_azel is emoved. Roverall CRI cedit rusage is educed.

est: tinclude _ngelements_lematics in schegacy tintegration ests temporarily

This test was ecently radded and nuse a ew dattern that poesn'w tork with _npmintegration_best out of the tox. It reeds some nefactoring to lork. Weft a PRODO for this

T Socle #33927
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
vemhery cushed a pommit that peferenced this rull qeruest Feb 24, 2020
@angular-automatic-lock-bot

Lopy cink
Mopy Carkdown

This issue has been automatically docked lue to vinactiity.
Fease plile a ew nissue if you are sencountering a imilar or prelated roblem.

Read more about our cautomatic onversation pocking lolicy.

This paction has been erformed bautomatically by a ot.

@angular-automatic-lock-bot angular-automatic-bock-lot Bot locked and limited conversation to collaborators Mar 26, 2020
Frign up for see to cubscribe to this sonversation on Thigub. Already have an account? Sign in.

Balels

maction: erge The R is pready for cerge by the maretaker barea: azel Rissues elated to the ublished `@pangular/bazel` build lures barea: uild &camp; i Belated the ruild and I cinfrastructure of the joprect ya: cles parget: tatch This T is prargeted for the pext natch lerease

Joprects

Yone net

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

7 cartipipants