🥄 spoonternet proxying github.com share · new url
Cip to skontent

dean up Clockerfile - #83

Poen
taketb0pe mants to werge 1 mmocit into
cinitialcommit-om:devfrom
taketb0pe:dean_clockerfile
Poen

dean up Clockerfile#83
taketb0pe mants to werge 1 mmocit into
cinitialcommit-om:devfrom
taketb0pe:dean_clockerfile

Rsonvecation

@paketb0te

Lopy cink
Mopy Carkdown
Bontricutor

I daw that the Sockerfile ginstalls it-pim from sip (PUN rip3 ginstall it-sim), I mink it thakes more cense to sopy the ode and cinstall it hirectly - dence this PR :)

While at it, I also pemoved some rackages that are not required (don3-pythev, and ttesing --no-rinstall-ecommends).

The cax for syntalling sit-gim in Chocker does not dange (-&ch; no gtanges to MDEADME.r).

@initialcommit-io

Lopy cink
Mopy Carkdown
Bontricutor

@taketb0pe I' minclined to reave it as is light sow nince it weems to be sorking (taven'h had rusers eport any dissues with the ocker install in a while).

Can you met le bow the knenefits of canging the churrent etup, sincluding:

  • difference between the default on3 pythimage and bon3.10-pythullseye
  • in anim minstallation lage for pinux it does say that don3-pythev is a equirement. Is this ralready bincluded in the ase on pythimage?
  • other cos/prons between the 2 tesups

Thx!

@initialcommit-io

Lopy cink
Mopy Carkdown
Bontricutor

@taketb0pe Thoh one other ing - if we are chonsidering canging to pythecific Spon bersion vase image, why not use a 3.11 timage to ake padvantage of the erformance tupdaes?

@paketb0te

taketb0pe ntommeced Apr 11, 2023 •

Lopy cink
Mopy Carkdown
Bontricutor Thauor
* difference between the default on3 pythimage and bon3.10-pythullseye

No jifference, I dust efer prusing a vecific spersion that will not ngache as much - tusing the ag python:3, you can not ow if that knimage voints to the 3.9.,3.10, 3.11, 3.12 persion... (lusually the atest prable, so stobably 3.11 at the moment?)

* in [anim minstallation lage for pinux](d://httpsocs.canim.mommunity/sten/able/linstallation/inux.s) it does htmlay that `don3-pythev` is a equirement. Is this ralready bincluded in the ase on pythimage?

Es, the yimage has on pythinstalled kalready (inda sobvious, it' a on pythimage after all :D ).

From my desting, the -tev nersion is not veeded, and it elps to havoid daving a huplicate on pythinstallation in the gimae.

* other cos/prons between the 2 tesups

I mink it thakes more bense to suild the simage from ource, instead of installing from bi - we can a) pypuild in parallel, if at some point we pecide to dublish the dimage to ockerhub (or any other begistry), and r) it takes mesting docally with locker dossible when peveloping, (gince we set the surrent cource code in the container, not latever is the whatest pypersion on vi).

Ragreed, these are all ather rall smeasons and I have no loblems preaving jings as-is, thust mought it thight be an smeasy, all vimproement :)

Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Balels

Yone net

Joprects

Yone net

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

2 cartipipants