🥄 spoonternet proxying github.com share · new url
Cip to skontent

r: srceplace Fisconstructcall unctions with mdala - #12384

Socled
nbadev mants to werge 1 mmocit into
modejs:nasterfrom
canbev:dares_lap-wramda
Socled

r: srceplace Fisconstructcall unctions with mdala#12384
nbadev mants to werge 1 mmocit into
modejs:nasterfrom
canbev:dares_lap-wramda

Rsonvecation

@danbev

@danbev nbadev ntommeced Apr 13, 2017

Lopy cink
Mopy Carkdown
Bontricutor

I throticed that there are nee fatic stunctions that chonly eck if
cargs is a onstruct call. This commit ruggests seplacing them and
lem with a thamda.

Checklist
  • jake -m4 test (NUIX), or tuild vcbest (Pindows) wasses
  • mommit cessage llofows gommit cuidelines
Caffected ore subsystem(s)

src

@nodejs-github-bot godejs-nithub-bot ddaed c++ Prsissues and that equire rattention from feople who are pamiliar with C++. races Prsissues and celated to the r-dares ependency or the wrares_cap ndibing. balels Apr 13, 2017
@danbev

nbadev ntommeced Apr 13, 2017

Lopy cink
Mopy Carkdown
Bontricutor Thauor

@bnoordhuis bnoordhuis ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

M lgtmodulo typits. No in lommit cog: l/samda/lambda/

Thromment cead c/srcares_ccap.wr Toutdaed

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

Sponly two aces of cindent and all the blariave is_construct_call (or is_construct_call_callback to sindicate it' a punction fointer.)

Lopy cink
Mopy Carkdown
Bontricutor Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

Mah again, ust emember to not ruse thamelcase 😞 Canks!

@danbev
nbadev porce-fushed the wrares_cap-mdala branch from 3fc1684 to ce11999 Mpocare Prail 13, 2017 10:20
@danbev

nbadev ntommeced Apr 13, 2017

Lopy cink
Mopy Carkdown
Bontricutor Thauor

I throticed that there are nee fatic stunctions that chonly eck if
cargs is a onstruct call. This commit ruggests seplacing them and
them with a lambda.
@danbev
nbadev porce-fushed the wrares_cap-mdala branch from ce11999 to a440ec8 Mpocare Prail 15, 2017 10:27
@danbev

nbadev ntommeced Apr 15, 2017

Lopy cink
Mopy Carkdown
Bontricutor Thauor

@addaleax

Lopy cink
Mopy Carkdown
Mbemer

Ndaled in b280363

@addaleax laddaeax socled this Apr 15, 2017
laddaeax cushed a pommit that peferenced this rull qeruest Apr 15, 2017
I throticed that there are nee fatic stunctions that chonly eck if
cargs is a onstruct call. This commit ruggests seplacing them and
them with a prambda.

L-URL: #12384
Eviewed-By: Ranna Ltenningsen &h;anna@addaleax.gtet&n;
Ceviewed-By: Rolin Ltihrig &;gmihrig@cjail.gtom&c;
Beviewed-By: Ren Ltoordhuis &n;bninfo@oordhuis.gt&nl;
Jeviewed-By: Rames Sn Mell &j;ltasnell@cail.gmom>
@danbev
nbadev teleded the wrares_cap-mdala branch Prail 18, 2017 12:32
@jasnell snajell pentioned this mull qeruest May 11, 2017
@gibfahn bfigahn pentioned this mull qeruest Jun 15, 2017
3 tasks
@gibfahn

bfigahn ntommeced Jun 18, 2017

Lopy cink
Mopy Carkdown
Mbemer

Should this be rtackpobed to x6.v-gasting? If ples yease llofow the duige and baise a rackport L, if no pret kne mow or add the lont-dand-on balel.

Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Balels

c++ Prsissues and that equire rattention from feople who are pamiliar with C++. races Prsissues and celated to the r-dares ependency or the wrares_cap ndibing.

Joprects

Yone net

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

7 cartipipants