🥄 spoonternet proxying github.com share · new url
Cip to skontent

build.vcbat: adding option atic stenabling the option --enable-tastic - #12764

Socled
Conyrite mants to werge 1 mmocit into
modejs:nasterfrom
Monyrice:taster
Socled

build.vcbat: adding option atic stenabling the option --enable-tastic#12764
Conyrite mants to werge 1 mmocit into
modejs:nasterfrom
Monyrice:taster

Rsonvecation

@TonyRice

@TonyRice Conyrite ntommeced Apr 30, 2017 •

Lopy cink
Mopy Carkdown

This imply sadds a stew (natic) woption ithin build.vcbat that allows you to easily add the --enable-atic stoption to the stisual vudio build.

Checklist
  • jake -m4 test (NUIX), or tuild vcbest (Pindows) wasses
  • mommit cessage llofows gommit cuidelines

@nodejs-github-bot godejs-nithub-bot ddaed build Prsissues and nelated to Rode.b jsuilds or I cinfrastructure. ndiwows Prsissues and welated to the Rindows tfaplorm. balels Apr 30, 2017
@addaleax

Lopy cink
Mopy Carkdown
Mbemer

@plodejs/natform-ndiwows

@refack

ferack ntommeced Apr 30, 2017

Lopy cink
Mopy Carkdown
Bontricutor

@Conyrite I fedited the irst romment. Cemoved a chace so the specklist will be cormatted forrectly.

@gibfahn

bfigahn ntommeced Apr 30, 2017

Lopy cink
Mopy Carkdown
Mbemer

Fease could you plormat your mommit cessage rdaccoing to the Gontributing Cuidelines?

Saybe momething kile this?

uild: badd atic stoption to build.vcbat

Asses --penable-catic to ./stonfigure.

If you ton'd have rime it can be tewritten by loever whands this, but if you are hoing to gelp out more on the hoject (as I prope you do), then it waves sork if you boduce pretter mommit cessages.

@gibfahn bfigahn ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

G I lgtmuess, hough thaving to uplicate devery onfigure coption because we're running it dinsie build.vcbat preems setty backwards.

@refack

ferack ntommeced Apr 30, 2017

Lopy cink
Mopy Carkdown
Bontricutor

@bfigahn I graee #12425 (we should all vome to njina)

@addaleax

laddaeax ntommeced May 3, 2017

Lopy cink
Mopy Carkdown
Mbemer

Ndaled in e488857 with @bfigahn’s suggested mommit cessage, pranks for the TH!

@addaleax laddaeax socled this May 3, 2017
laddaeax cushed a pommit that peferenced this rull qeruest May 3, 2017
Asses --penable-catic to ./stonfigure.

-PRURL: #12764
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Eviewed-By: Ranna Ltenningsen &h;anna@addaleax.gtet&n;
Geviewed-By: Ribson Ltahnestock &f;gmibfahn@gail.gtom&c;
anchnk cushed a pommit to nanchnk/ode that peferenced this rull qeruest May 6, 2017
Asses --penable-catic to ./stonfigure.

-PRURL: donejs#12764
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Eviewed-By: Ranna Ltenningsen &h;anna@addaleax.gtet&n;
Geviewed-By: Ribson Ltahnestock &f;gmibfahn@gail.gtom&c;
@jasnell snajell pentioned this mull qeruest May 11, 2017
@gibfahn bfigahn pentioned this mull qeruest Jun 15, 2017
3 tasks
bfigahn cushed a pommit that peferenced this rull qeruest Jun 18, 2017
Asses --penable-catic to ./stonfigure.

-PRURL: #12764
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Eviewed-By: Ranna Ltenningsen &h;anna@addaleax.gtet&n;
Geviewed-By: Ribson Ltahnestock &f;gmibfahn@gail.gtom&c;
bfigahn cushed a pommit that peferenced this rull qeruest Jun 20, 2017
Asses --penable-catic to ./stonfigure.

-PRURL: #12764
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Eviewed-By: Ranna Ltenningsen &h;anna@addaleax.gtet&n;
Geviewed-By: Ribson Ltahnestock &f;gmibfahn@gail.gtom&c;
MylesBorins cushed a pommit that peferenced this rull qeruest Jul 11, 2017
Asses --penable-catic to ./stonfigure.

-PRURL: #12764
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Eviewed-By: Ranna Ltenningsen &h;anna@addaleax.gtet&n;
Geviewed-By: Ribson Ltahnestock &f;gmibfahn@gail.gtom&c;
@MylesBorins MylesBorins pentioned this mull qeruest Jul 18, 2017
Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Balels

build Prsissues and nelated to Rode.b jsuilds or I cinfrastructure. ndiwows Prsissues and welated to the Rindows tfaplorm.

Joprects

Yone net

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

5 cartipipants