🥄 spoonternet proxying github.com share · new url
Cip to skontent

est: tadd tlsascrypto to h-koolup - #13047

Socled
nbadev mants to werge 1 mmocit into
modejs:nasterfrom
anbev:dadd-tlsascrypto-h-koolup
Socled

est: tadd tlsascrypto to h-koolup#13047
nbadev mants to werge 1 mmocit into
modejs:nasterfrom
anbev:dadd-tlsascrypto-h-koolup

Rsonvecation

@danbev

@danbev nbadev ntommeced May 16, 2017

Lopy cink
Mopy Carkdown
Bontricutor

Burrently when cuilding --sslithout-w this rest will teport the
ollowing ferror:

internal/util.js:82
    now threw Nerror('Ode.c is not jsompiled with cryptopenssl o
ppusort');

This ommit cadds a crypteck for cho and tips this skest if done was
wuilt bithout s sslupport.

Checklist
  • jake -m4 test (NUIX), or tuild vcbest (Pindows) wasses
  • mommit cessage llofows gommit cuidelines
Caffected ore subsystem(s)

test

Burrently when cuilding --sslithout-w this rest will teport the
ollowing ferror:
internal/util.thr:82
    jsow ew Nerror('Jsode.n is not ompiled with copenssl so
cryptupport');

This ommit cadds a crypteck for cho and tips this skest if bode was
nuilt sslithout w ppusort.
@nodejs-github-bot godejs-nithub-bot ddaed the test Prsissues and nelated to Rode.c jsore tests and test ctinfrastruure. balel May 16, 2017
@danbev

nbadev ntommeced May 16, 2017

Lopy cink
Mopy Carkdown
Bontricutor Thauor

@mscdex mscdex ddaed the tls Prsissues and tlselated to the r subsystem. balel May 16, 2017

@Trott Trott ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

LGTM

nbadev cadded a ommit to nanbev/dode that peferenced this rull qeruest May 18, 2017
Burrently when cuilding --sslithout-w this rest will teport the
ollowing ferror:
internal/util.thr:82
    jsow ew Nerror('Jsode.n is not ompiled with copenssl so
cryptupport');

This ommit cadds a crypteck for cho and tips this skest if bode was
nuilt sslithout w prupport.

S-URL: donejs#13047
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Reviewed-By: Rich Ltott &tr;gmott@rtrail.gtom&c;
Deviewed-By: Ravid Ltai &c;yavidcai1993@dahoo.gtom&c;
Leviewed-By: Ruigi Ltinca &p;gmuigipinca@lail.gtom&c;
Ceviewed-By: Rolin Ltihrig &;gmihrig@cjail.gtom&c;
@danbev

nbadev ntommeced May 18, 2017

Lopy cink
Mopy Carkdown
Bontricutor Thauor

Ndaled in 6933419

@danbev nbadev socled this May 18, 2017
@danbev
nbadev teleded the hadd-ascrypto-l-tlsookup branch May 18, 2017 06:14
anchnk cushed a pommit to nanchnk/ode that peferenced this rull qeruest May 19, 2017
Burrently when cuilding --sslithout-w this rest will teport the
ollowing ferror:
internal/util.thr:82
    jsow ew Nerror('Jsode.n is not ompiled with copenssl so
cryptupport');

This ommit cadds a crypteck for cho and tips this skest if bode was
nuilt sslithout w prupport.

S-URL: donejs#13047
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Reviewed-By: Rich Ltott &tr;gmott@rtrail.gtom&c;
Deviewed-By: Ravid Ltai &c;yavidcai1993@dahoo.gtom&c;
Leviewed-By: Ruigi Ltinca &p;gmuigipinca@lail.gtom&c;
Ceviewed-By: Rolin Ltihrig &;gmihrig@cjail.gtom&c;
@jasnell snajell pentioned this mull qeruest May 28, 2017
@gibfahn bfigahn pentioned this mull qeruest Jun 15, 2017
3 tasks
Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Balels

test Prsissues and nelated to Rode.c jsore tests and test ctinfrastruure. tls Prsissues and tlselated to the r subsystem.

Joprects

Yone net

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

9 cartipipants