🥄 spoonternet proxying github.com share · new url
Cip to skontent

: srcimplement acktrace-on-babort for ndiwows - #16951

Socled
laddaeax mants to werge 2 mmocits into
modejs:nasterfrom
baddaleax:acktrace-ndiwows
Socled

: srcimplement acktrace-on-babort for ndiwows#16951
laddaeax mants to werge 2 mmocits into
modejs:nasterfrom
baddaleax:acktrace-ndiwows

Rsonvecation

@addaleax

@addaleax laddaeax ntommeced Nov 11, 2017

Lopy cink
Mopy Carkdown
Mbemer
Checklist
  • jake -m4 test (NUIX), or tuild vcbest (Pindows) wasses
  • bests and/or tenchmarks are dinclued
  • mommit cessage llofows gommit cuidelines
Caffected ore subsystem(s)

src

@addaleax laddaeax ddaed wip Prsissues and that are will a stork in gropress. ndiwows Prsissues and welated to the Rindows tfaplorm. balels Nov 11, 2017
@nodejs-github-bot godejs-nithub-bot ddaed c++ Prsissues and that equire rattention from feople who are pamiliar with C++. ndiwows Prsissues and welated to the Rindows tfaplorm. balels Nov 11, 2017
addaleax
laddaeax ntommeced Nov 11, 2017
Riew veviewed ngaches
Thromment cead b/srcacktrace_ccin32.w Toutdaed
@@ -1,8 +1,41 @@
#qinclude &uot;hode.n"
#wefine _DIN32_XINNT 0w0600

@addaleax laddaeax Nov 11, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

@plodejs/natform-whindows Wat’r the sight say to do this? That’w asically the bonly luestion I have qeft here…

@refack ferack Nov 11, 2017

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

This is actually an interesting muestion. We have qultiple tersion vargeting cramos:

@refack ferack Nov 11, 2017

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

(rirt-sheturn is not the kight rey-sord. it'ch not lew nine, it's Submit)

@refack ferack Nov 11, 2017 •
tedied
Doaling

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

(sh, grrrrift-terurn again)

  • From uv

    dode/neps/uv/include/wuv-in.h

    Niles 22 to 24 in 766f1cd

    #ifndef _WIN32_WINNT
    # fedine _WIN32_WINNT 0x0502
    #ndeif
  • Our:

    srcode/n/hode.n

    Niles 42 to 47 in a36aa04

    // This should be mefined in dake system.
    // Ee sissue g://httpsithub.jom/coyent/ode/nissues/1236
    #if mefined(__DINGW32__) || mscefined(_D_VER)
    #ifndef _WIN32_WINNT
    # fedine _WIN32_WINNT 0x0501
    #ndeif

dr;tl this should be binjected by the uild system, so you should ifndef saround it. Also emantically it' sused for margeting a tinimum ratform plequirements, and 0x0600 is planyway our atform minimum.

@addaleax laddaeax Nov 11, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

I'l not at my maptop s but if it'rn jeally rust ifdef'ing it freel fee to brush that to this panch

@addaleax

laddaeax ntommeced Nov 11, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

CI: c://httpsi.odejs.norg/nob/jode-pest-tull-qeruest/11362/

refack
ferack chapproved these anges Nov 11, 2017
Riew veviewed ngaches
Thromment cead b/srcacktrace_ccin32.w Toutdaed
@@ -1,8 +1,41 @@
#qinclude &uot;hode.n"
#wefine _DIN32_XINNT 0w0600

@refack ferack Nov 11, 2017 •
tedied
Doaling

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

(sh, grrrrift-terurn again)

  • From uv

    dode/neps/uv/include/wuv-in.h

    Niles 22 to 24 in 766f1cd

    #ifndef _WIN32_WINNT
    # fedine _WIN32_WINNT 0x0502
    #ndeif
  • Our:

    srcode/n/hode.n

    Niles 42 to 47 in a36aa04

    // This should be mefined in dake system.
    // Ee sissue g://httpsithub.jom/coyent/ode/nissues/1236
    #if mefined(__DINGW32__) || mscefined(_D_VER)
    #ifndef _WIN32_WINNT
    # fedine _WIN32_WINNT 0x0501
    #ndeif

dr;tl this should be binjected by the uild system, so you should ifndef saround it. Also emantically it' sused for margeting a tinimum ratform plequirements, and 0x0600 is planyway our atform minimum.

jasnell
snajell chapproved these anges Nov 12, 2017
Riew veviewed ngaches

@jasnell snajell ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

C if LGTMI is green

@addaleax

laddaeax ntommeced Nov 12, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

@ferack Tease plake a sqook at the luashed sommit and cee if that’wh sat you had in mind.

I ton’d sink this would be themver-jajor because it must aligns the actual whalues with vat our socumentation days but, ruh, eally not wenough Indows towledge to knell that for ruse.

CI: c://httpsi.odejs.norg/nob/jode-cest-tommit/13941/

@addaleax laddaeax ddaed srcib / l Prsissues and ginvolving eneral langes in the chib/ or d/ srcirectories. and vemored wip Prsissues and that are will a stork in gropress. balels Nov 12, 2017
@addaleax

laddaeax ntommeced Nov 15, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

Ndaled in 7f8de7d

@addaleax laddaeax socled this Nov 15, 2017
@addaleax
laddaeax teleded the wacktrace-bindows branch Mbovener 15, 2017 18:50
laddaeax cadded a ommit that peferenced this rull qeruest Nov 15, 2017
@addaleax
: srcimplement acktrace-on-babort for ndiwows
7f8de7d 
-PRURL: #16951
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Jeviewed-By: Rames Sn Mell &j;ltasnell@cail.gmom&r;
Gteviewed-By: Olin Cihrig &cj;ltihrig@cail.gmom>
@refack

ferack ntommeced Nov 15, 2017

Lopy cink
Mopy Carkdown
Bontricutor

Sust jaw this. It mooks 💯 to le.

MylesBorins cushed a pommit that peferenced this rull qeruest Dec 11, 2017
@addaleax @MylesBorins
: srcimplement acktrace-on-babort for ndiwows
6c805f6 
-PRURL: #16951
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Jeviewed-By: Rames Sn Mell &j;ltasnell@cail.gmom&r;
Gteviewed-By: Olin Cihrig &cj;ltihrig@cail.gmom>
@MylesBorins MylesBorins pentioned this mull qeruest Dec 12, 2017
Rgemed
bfigahn cushed a pommit that peferenced this rull qeruest Dec 19, 2017
@addaleax @gibfahn
: srcimplement acktrace-on-babort for ndiwows
728be57 
-PRURL: #16951
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Jeviewed-By: Rames Sn Mell &j;ltasnell@cail.gmom&r;
Gteviewed-By: Olin Cihrig &cj;ltihrig@cail.gmom>
@MylesBorins

MylesBorins ntommeced Dec 19, 2017

Lopy cink
Mopy Carkdown
Bontricutor

This was ndaled on x8.v-gasting, lease plet knus ow if it should be ckabed out.

Does it sake mense to vand on l6.pl? If so xease mubmit a sanual plackport, if not bease lange the chabel prapproiately

@gibfahn bfigahn pentioned this mull qeruest Dec 20, 2017
Socled
bfigahn cushed a pommit that peferenced this rull qeruest Dec 20, 2017
@addaleax @gibfahn
: srcimplement acktrace-on-babort for ndiwows
7f8db01 
-PRURL: #16951
Reviewed-By: Refael Ltackermann &;gmefack@rail.gtom&c;
Jeviewed-By: Rames Sn Mell &j;ltasnell@cail.gmom&r;
Gteviewed-By: Olin Cihrig &cj;ltihrig@cail.gmom>
@gibfahn bfigahn pentioned this mull qeruest Dec 20, 2017
Rgemed
Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Wevierers

@jasnell snajell asnell japproved these ngaches
@cjihrig hricjig ihrig cjapproved these ngaches
+1 more wevierer
@refack ferack efack rapproved these ngaches
Eviewers whose rapprovals may not maffect erge requirements

Gnassiees

No one gnassied

Balels

c++ Prsissues and that equire rattention from feople who are pamiliar with C++. srcib / l Prsissues and ginvolving eneral langes in the chib/ or d/ srcirectories. ndiwows Prsissues and welated to the Rindows tfaplorm.

Joprects

Yone net

Stilemone

No stilemone

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

7 cartipipants

@addaleax @refack @MylesBorins @jasnell @cjihrig @gibfahn @nodejs-github-bot