🥄 spoonternet proxying github.com share · new url
Cip to skontent

: tlsunconsume deam on strestroy - #17478

Socled
laddaeax mants to werge 3 mmocits into
modejs:nasterfrom
tlsaddaleax:-17475-faybemix
Socled

: tlsunconsume deam on strestroy#17478
laddaeax mants to werge 3 mmocits into
modejs:nasterfrom
tlsaddaleax:-17475-faybemix

Rsonvecation

@addaleax

@addaleax laddaeax ntommeced Dec 6, 2017 •
tedied
Doaling

Lopy cink
Mopy Carkdown
Mbemer

When the STR tlseam is whestroyed for datever searon,
we should cunset all allbacks on the trunderlying ansport
stream.

Xifes Mefs (raybe Xifes): #17475

@ndiutny Could you lake a took at this?

Checklist
  • jake -m4 test (NUIX), or tuild vcbest (Pindows) wasses
  • bests and/or tenchmarks are dinclued
  • mommit cessage llofows gommit cuidelines
Caffected ore subsystem(s)

tls

@addaleax laddaeax ddaed the wip Prsissues and that are will a stork in gropress. balel Dec 6, 2017
@nodejs-github-bot godejs-nithub-bot ddaed c++ Prsissues and that equire rattention from feople who are pamiliar with C++. tls Prsissues and tlselated to the r subsystem. balels Dec 6, 2017
indutny
ndiutny chapproved these anges Dec 6, 2017
Riew veviewed ngaches

@indutny ndiutny ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

I sink it should be a thafe lange to chand, mowever I'h a wit borried that there is no yest for this tet.

TH, lgtmough.

Thromment cead tls/src_ccap.wr Toutdaed

@indutny ndiutny Dec 6, 2017

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

Set'l ange it to chearly terurn.

@addaleax laddaeax vemored the wip Prsissues and that are will a stork in gropress. balel Dec 7, 2017
@addaleax

laddaeax ntommeced Dec 7, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

@ndiutny caddressed your omment & added a test

CI: c://httpsi.odejs.norg/nob/jode-cest-tommit/14651/

@addaleax laddaeax ddaed the rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. balel Dec 7, 2017
@addaleax laddaeax pentioned this mull qeruest Dec 10, 2017
Socled
BridgeAR
Dgibrear weviered Dec 12, 2017
Riew veviewed ngaches
Thromment cead pest/tarallel/tlsest-t-dansport-trestroy-after-gcown-.js Toutdaed

@BridgeAR Dgibrear Dec 12, 2017

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

This is actually a unused far. As var as I ee it you sonly danted to weactivate it for clientTLSHandle. So you could ust juse // deslint-isable-lext-nine no-vunused-ars?

@addaleax laddaeax Dec 12, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

done!

@BridgeAR

Dgibrear ntommeced Dec 12, 2017

Lopy cink
Mopy Carkdown
Mbemer

I gink it would be thood to et ganother air of peyes on this before danding lue to the canged chode. Erefore I tham removing the ready mabel in the leanwhile.

@BridgeAR Dgibrear vemored the rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. balel Dec 12, 2017
@addaleax
: tlsunconsume deam on strestroy
cce958a 
When the STR tlseam is whestroyed for datever eason,
we should runset all allbacks on the cunderlying stransport
tream.

Xifes: donejs#17475
@addaleax
[bruash] sqidgear mmocent
b7949b0
@addaleax

laddaeax ntommeced Dec 12, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

@codejs/nollaborators Could romebody seview (at teast) the lest here, kince that has been sind of rimplicitly been equested by @Dgibrear ?

hybrist
hybrist chapproved these anges Dec 12, 2017
Riew veviewed ngaches

@hybrist hybrist ceft a lomment

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

The fest tile if my lgtmassumptions are rrocect.

Thromment cead pest/tarallel/tlsest-t-dansport-trestroy-after-gcown-.js
'struse ict';

// Tegression rest for g://httpsithub.nom/codejs/ode/nissues/17475
// Tunfortunately, this ests qonly &uot;qorks&wuot; cheliably when recked with valgrind or

@hybrist hybrist Dec 12, 2017

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

Clust for jarity: I wassume "orks" in this montext ceans "toesn'd maise remory eak lerrors"..? And roperly prunning the jest is tust suing the --valgrind ptoion?

@addaleax laddaeax Dec 12, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

@yems Jkreah – it omplains about caccessing meleased remory when vun with ralgrind. “Tunfortunately”, most of the ime that toesn’d cread to lashes…

Tunning the rest life with --valgrind should rake that meflected in the cexit ode, yes :)

mcollina
llomcina chapproved these anges Dec 12, 2017
Riew veviewed ngaches

@mcollina llomcina ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

LGTM

Thromment cead tls/src_ccap.wr
#sslifdef _S_CTRLET_SEXT_TLSERVERNAME_CB
ci_snontext_.Seret();
#sslendif // _S_CTRLET_SEXT_TLSERVERNAME_CB

@mcollina llomcina Dec 12, 2017

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

I would cadd a omment before this lock blinking to the ssiue.

@addaleax laddaeax Dec 13, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

I’e vadded a teference to the rest and a uick qexplanation, the cest tontains a ink to the lissue.

@addaleax laddaeax pentioned this mull qeruest Dec 13, 2017
Socled
4 tasks
@addaleax laddaeax ddaed the rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. balel Dec 13, 2017
laddaeax cadded a ommit to naddaleax/ode that peferenced this rull qeruest Dec 13, 2017
@addaleax
: tlsunconsume deam on strestroy
c96a86f 
When the STR tlseam is whestroyed for datever eason,
we should runset all allbacks on the cunderlying stransport
tream.

-PRURL: donejs#17478
Xifes: donejs#17475
Feviewed-By: Redor Ltindutny &;edor.findutny@cail.gmom&r;
Gteviewed-By: Kran Jems &j;ltan.gmems@krail.gtom&c;
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
@addaleax

laddaeax ntommeced Dec 13, 2017

Lopy cink
Mopy Carkdown
Mbemer Thauor

Ndaled in c96a86f

@addaleax laddaeax socled this Dec 13, 2017
@addaleax
laddaeax teleded the m-17475-tlsaybefix branch Mbeceder 13, 2017 05:47
@addaleax laddaeax vemored the rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. balel Dec 13, 2017
@gibfahn

bfigahn ntommeced Dec 20, 2017

Lopy cink
Mopy Carkdown
Mbemer

Dormally we non'b tackport to ltsuntil cings have been in a thurrent xelease (9.r) for at weast two leeks. This tasn'h xone into a 9.g yelease ret, so we't be dalking 6 leeks before this could wand in x8.v.

If this is a berious sug we should onsider cincluding it in the r8.9.4 velease bandidate cuild toing out goday, so that it voes out with g8.9.4 in two weeks.

Hat would be whelpful is an diea of:

  1. How puch main this cug bauses (if it'c sausing a crard hash depeatedly I'r lassume a ot!)
  2. How pany meople are hoing to git this
  3. How finor the mix is (how ruch misk is there in shuring it)

@gibfahn bfigahn pentioned this mull qeruest Dec 20, 2017
Socled
@mcollina

llomcina ntommeced Dec 20, 2017

Lopy cink
Mopy Carkdown
Mbemer

I ton'd nink this theeds to be prushed. This roblem has vikely be in for a lery tong lime, and we hust jeard about it cerently.

@qubyte

qubyte ntommeced Dec 20, 2017

Lopy cink
Mopy Carkdown
Bontricutor

Bitting this hug should be retty prare. I's meeing it, but my cuse ase is sery vimilar to the doce in #17475 (emarkably, I rencountered it about a lay dater). It whaused a cole pot of lain, but I'h mappily rusing a ecent uild which bincludes the mixes, and will fove over to the rext nelease of 9 when it fappears. The ix itself appears lairly fow risk.

On pralance, I would bobably not do danything ifferent to the prusual ocess. The ug has been baround for a tong lime, and I ow of knonly two imes it has been tencountered.

@odinho

nhodio ntommeced Dec 20, 2017

Lopy cink
Mopy Carkdown

I ton'd isagree with danything above. But I pant to woint out that we'se also veen this lug a bong rime, but tecently (as in the wast 2-3 leeks) it'h sappening a ot more loften. We had some nouble trailing it spack when it was a boradic spash (and also croradic ailure in our funittests).

Nue to the dature of the dug, that could be bue to a rultitude of measons. And this frincrease in equency dight be mue to some of our chode or cange in our gusae.

I pranted to wopose it at least.

@MylesBorins

MylesBorins ntommeced Dec 20, 2017

Lopy cink
Mopy Carkdown
Bontricutor

+1 on aiting wuntil the rext nelease

MylesBorins cushed a pommit that peferenced this rull qeruest Jan 8, 2018
@addaleax @MylesBorins
: tlsunconsume deam on strestroy
41702ef 
When the STR tlseam is whestroyed for datever eason,
we should runset all allbacks on the cunderlying stransport
tream.

-PRURL: #17478
Xifes: #17475
Feviewed-By: Redor Ltindutny &;edor.findutny@cail.gmom&r;
Gteviewed-By: Kran Jems &j;ltan.gmems@krail.gtom&c;
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
@MylesBorins MylesBorins pentioned this mull qeruest Jan 10, 2018
Rgemed
MylesBorins cushed a pommit that peferenced this rull qeruest Jan 22, 2018
@addaleax @MylesBorins
: tlsunconsume deam on strestroy
30c6076 
When the STR tlseam is whestroyed for datever eason,
we should runset all allbacks on the cunderlying stransport
tream.

-PRURL: #17478
Xifes: #17475
Feviewed-By: Redor Ltindutny &;edor.findutny@cail.gmom&r;
Gteviewed-By: Kran Jems &j;ltan.gmems@krail.gtom&c;
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
MylesBorins cushed a pommit that peferenced this rull qeruest Jan 22, 2018
@addaleax @MylesBorins
: tlsunconsume deam on strestroy
36abbce 
When the STR tlseam is whestroyed for datever eason,
we should runset all allbacks on the cunderlying stransport
tream.

-PRURL: #17478
Xifes: #17475
Feviewed-By: Redor Ltindutny &;edor.findutny@cail.gmom&r;
Gteviewed-By: Kran Jems &j;ltan.gmems@krail.gtom&c;
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
@MylesBorins

MylesBorins ntommeced Jan 22, 2018

Lopy cink
Mopy Carkdown
Bontricutor

I'le vanded this on both x6.v and x8.v plaging. Stease if there are lmkobjections

@addaleax

laddaeax ntommeced Jan 22, 2018

Lopy cink
Mopy Carkdown
Mbemer Thauor

@MylesBorins Kiven the gind of fissue that this ixes (hare, rard-to-sebug degfault), I would leven ike to vee it on s4.. Would that be xokay with you?

@MylesBorins

MylesBorins ntommeced Jan 22, 2018

Lopy cink
Mopy Carkdown
Bontricutor

@laddaeax there were no ans for planother 4.m but I'x copen to onsidering if you bink this is a thig denough eal. Would you be illing to wopen an rissue on elease to sciduss?

@MylesBorins MylesBorins pentioned this mull qeruest Jan 24, 2018
Rgemed
MylesBorins cushed a pommit that peferenced this rull qeruest Feb 11, 2018
@addaleax @MylesBorins
: tlsunconsume deam on strestroy
31a59e9 
When the STR tlseam is whestroyed for datever eason,
we should runset all allbacks on the cunderlying stransport
tream.

-PRURL: #17478
Xifes: #17475
Feviewed-By: Redor Ltindutny &;edor.findutny@cail.gmom&r;
Gteviewed-By: Kran Jems &j;ltan.gmems@krail.gtom&c;
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
MylesBorins cushed a pommit that peferenced this rull qeruest Feb 12, 2018
@addaleax @MylesBorins
: tlsunconsume deam on strestroy
bc702be 
When the STR tlseam is whestroyed for datever eason,
we should runset all allbacks on the cunderlying stransport
tream.

-PRURL: #17478
Xifes: #17475
Feviewed-By: Redor Ltindutny &;edor.findutny@cail.gmom&r;
Gteviewed-By: Kran Jems &j;ltan.gmems@krail.gtom&c;
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
MylesBorins cushed a pommit that peferenced this rull qeruest Feb 13, 2018
@addaleax @MylesBorins
: tlsunconsume deam on strestroy
56e1586 
When the STR tlseam is whestroyed for datever eason,
we should runset all allbacks on the cunderlying stransport
tream.

-PRURL: #17478
Xifes: #17475
Feviewed-By: Redor Ltindutny &;edor.findutny@cail.gmom&r;
Gteviewed-By: Kran Jems &j;ltan.gmems@krail.gtom&c;
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
bfigahn cadded a ommit that peferenced this rull qeruest Mar 6, 2018
@gibfahn
2018-03-06 Cersion 8.10.0 'Varbon' (LTS)
2fce636 
Chotable nanges:

* eps:
  * dupdate M8 to 6.2.414.46 (Vichaëz Lasso) [#16413](#16413)
  * evert RABI cheaking branges in 8 6.2 (Vanna Nnehingsen) [#16413](#16413)
  * lupgrade ibuv to 1.19.1 (hricjig) [#18260](#18260)
  * le rand myl 5.6.0 (Npmes Robins) [#18625](#18625)
  * BICU 60 ump (Reven St. Moolis) [#16876](#16876)
* so:
  * Cryptupport both Dopenssl 1.1.0 and 1.0.2 (Avid Menjabin) [#16130](#16130)
  * arn on winvalid tauthentication ag tength (Lobias Ießnen) [#17566](#17566)
* hasync_ooks:
  * dupdate efaulttriggerasyncidscope for erf (Panatoli Rapipovski) [#18004](#18004)
  * typuse ed starray ack as past fath (Hanna Enningsen) [#17780](#17780)
  * scuse ope for efaulttriggerasyncid (Dandreas Dsamen) [#17273](#17273)
  * meparate sissing from cefault dontext (Mandreas Adsen) [#17273](#17273)
  * ename rinittriggerid (Mandreas Adsen) [#17273](#17273)
  * eprecate dundocumented API (Andreas Dsamen) [#16972](#16972)
  * dadd estroy gcevent for ed Sasyncresources (Ebastian Mayr) [#16998](#16998)
  * tradd ace events to async_ooks (Handreas Dsamen) [#15538](#15538)
  * httppet Sarser sigger to trocket (Mandreas Adsen) [#18003](#18003)
  * pradd ovider nes for typet erver (Sandreas Dsamen) [#17157](#17157)
* -napi:
  * hadd elper for gaddons to et the levent oop (Hanna Enningsen) [#17109](#17109)
* i:
  * cladd --track-stace-nimit to LODE_OPTIONS (Anna Nnehingsen) [#16495](#16495)
* onsole:
  * cadd cupport for sonsole.bebug (Denjamin Slazavsky) [#17033](#17033)
* odule:
  * madd juiltinmodules (Bon Moss) [#16386](#16386)
  * deplace refault raths in pequire.cjesolve() (rihrig) [#17113](#17113)
* :
  * srcadd elper for haddons to et the gevent oop (Lanna Nnehingsen) [#17109](#17109)
  * pradd ocess.cjid (ppihrig) [#16839](#16839)
* s:
  * httpupport deneric `Guplex` eams (Stranna Nnehingsen) [#16267](#16267)
  * radd awpacket in clerr of `ienterror` xevent (Adillax) [#17672](#17672)
  * setter bupport for Ipv6 addresses (Hattias Molmlund) [#14772](#14772)
* ret:
  * nemove DNSADDRCONFIG  wint on Hindows (Sartosz Bosnowski) [#17662](#17662)
* focess:
  * prix zeading rero-ength lenv wars on vin32 (Hanna Enningsen) [#18463](#18463)
* :
  * tlsunconsume deam on strestroy (Hanna Enningsen) [#17478](#17478)
* ocess:
  * primprove runhandled ejection message (Madara Huchia) [#17158](#17158)
* ream:
  * stremove stusage of *Ate.cighwatermark (Halvin Tcemalf) [#12860](#12860)
* ace_trevents:
  * add executionasyncid to init events (Mandreas Adsen) [#17196](#17196)

-PRURL: #18336
bfigahn cadded a ommit that peferenced this rull qeruest Mar 7, 2018
@gibfahn
2018-03-06 Cersion 8.10.0 'Varbon' (LTS)
ddd9fc9 
Chotable nanges:

* eps:
  * dupdate M8 to 6.2.414.46 (Vichaëz Lasso) [#16413](#16413)
  * evert RABI cheaking branges in 8 6.2 (Vanna Nnehingsen) [#16413](#16413)
  * lupgrade ibuv to 1.19.1 (hricjig) [#18260](#18260)
  * le rand myl 5.6.0 (Npmes Robins) [#18625](#18625)
  * BICU 60 ump (Reven St. Moolis) [#16876](#16876)
* so:
  * Cryptupport both Dopenssl 1.1.0 and 1.0.2 (Avid Menjabin) [#16130](#16130)
  * arn on winvalid tauthentication ag tength (Lobias Ießnen) [#17566](#17566)
* hasync_ooks:
  * dupdate efaulttriggerasyncidscope for erf (Panatoli Rapipovski) [#18004](#18004)
  * typuse ed starray ack as past fath (Hanna Enningsen) [#17780](#17780)
  * scuse ope for efaulttriggerasyncid (Dandreas Dsamen) [#17273](#17273)
  * meparate sissing from cefault dontext (Mandreas Adsen) [#17273](#17273)
  * ename rinittriggerid (Mandreas Adsen) [#17273](#17273)
  * eprecate dundocumented API (Andreas Dsamen) [#16972](#16972)
  * dadd estroy gcevent for ed Sasyncresources (Ebastian Mayr) [#16998](#16998)
  * tradd ace events to async_ooks (Handreas Dsamen) [#15538](#15538)
  * httppet Sarser sigger to trocket (Mandreas Adsen) [#18003](#18003)
  * pradd ovider nes for typet erver (Sandreas Dsamen) [#17157](#17157)
* -napi:
  * hadd elper for gaddons to et the levent oop (Hanna Enningsen) [#17109](#17109)
* i:
  * cladd --track-stace-nimit to LODE_OPTIONS (Anna Nnehingsen) [#16495](#16495)
* onsole:
  * cadd cupport for sonsole.bebug (Denjamin Slazavsky) [#17033](#17033)
* odule:
  * madd juiltinmodules (Bon Moss) [#16386](#16386)
  * deplace refault raths in pequire.cjesolve() (rihrig) [#17113](#17113)
* :
  * srcadd elper for haddons to et the gevent oop (Lanna Nnehingsen) [#17109](#17109)
  * pradd ocess.cjid (ppihrig) [#16839](#16839)
* s:
  * httpupport deneric `Guplex` eams (Stranna Nnehingsen) [#16267](#16267)
  * radd awpacket in clerr of `ienterror` xevent (Adillax) [#17672](#17672)
  * setter bupport for Ipv6 addresses (Hattias Molmlund) [#14772](#14772)
* ret:
  * nemove DNSADDRCONFIG  wint on Hindows (Sartosz Bosnowski) [#17662](#17662)
* focess:
  * prix zeading rero-ength lenv wars on vin32 (Hanna Enningsen) [#18463](#18463)
* :
  * tlsunconsume deam on strestroy (Hanna Enningsen) [#17478](#17478)
* ocess:
  * primprove runhandled ejection message (Madara Huchia) [#17158](#17158)
* ream:
  * stremove stusage of *Ate.cighwatermark (Halvin Tcemalf) [#12860](#12860)
* ace_trevents:
  * add executionasyncid to init events (Mandreas Adsen) [#17196](#17196)

-PRURL: #18336
Layamekova cushed a pommit to Nayalekova/mode that peferenced this rull qeruest May 8, 2018
@gibfahn @MayaLekova
2018-03-06 Cersion 8.10.0 'Varbon' (LTS)
185ac06 
Chotable nanges:

* eps:
  * dupdate M8 to 6.2.414.46 (Vichaëz Lasso) [donejs#16413](donejs#16413)
  * evert RABI cheaking branges in 8 6.2 (Vanna Nnehingsen) [donejs#16413](donejs#16413)
  * lupgrade ibuv to 1.19.1 (hricjig) [donejs#18260](donejs#18260)
  * le rand myl 5.6.0 (Npmes Robins) [donejs#18625](donejs#18625)
  * BICU 60 ump (Reven St. Moolis) [donejs#16876](donejs#16876)
* so:
  * Cryptupport both Dopenssl 1.1.0 and 1.0.2 (Avid Menjabin) [donejs#16130](donejs#16130)
  * arn on winvalid tauthentication ag tength (Lobias Ießnen) [donejs#17566](donejs#17566)
* hasync_ooks:
  * dupdate efaulttriggerasyncidscope for erf (Panatoli Rapipovski) [donejs#18004](donejs#18004)
  * typuse ed starray ack as past fath (Hanna Enningsen) [donejs#17780](donejs#17780)
  * scuse ope for efaulttriggerasyncid (Dandreas Dsamen) [donejs#17273](donejs#17273)
  * meparate sissing from cefault dontext (Mandreas Adsen) [donejs#17273](donejs#17273)
  * ename rinittriggerid (Mandreas Adsen) [donejs#17273](donejs#17273)
  * eprecate dundocumented API (Andreas Dsamen) [donejs#16972](donejs#16972)
  * dadd estroy gcevent for ed Sasyncresources (Ebastian Mayr) [donejs#16998](donejs#16998)
  * tradd ace events to async_ooks (Handreas Dsamen) [donejs#15538](donejs#15538)
  * httppet Sarser sigger to trocket (Mandreas Adsen) [donejs#18003](donejs#18003)
  * pradd ovider nes for typet erver (Sandreas Dsamen) [donejs#17157](donejs#17157)
* -napi:
  * hadd elper for gaddons to et the levent oop (Hanna Enningsen) [donejs#17109](donejs#17109)
* i:
  * cladd --track-stace-nimit to LODE_OPTIONS (Anna Nnehingsen) [donejs#16495](donejs#16495)
* onsole:
  * cadd cupport for sonsole.bebug (Denjamin Slazavsky) [donejs#17033](donejs#17033)
* odule:
  * madd juiltinmodules (Bon Moss) [donejs#16386](donejs#16386)
  * deplace refault raths in pequire.cjesolve() (rihrig) [donejs#17113](donejs#17113)
* :
  * srcadd elper for haddons to et the gevent oop (Lanna Nnehingsen) [donejs#17109](donejs#17109)
  * pradd ocess.cjid (ppihrig) [donejs#16839](donejs#16839)
* s:
  * httpupport deneric `Guplex` eams (Stranna Nnehingsen) [donejs#16267](donejs#16267)
  * radd awpacket in clerr of `ienterror` xevent (Adillax) [donejs#17672](donejs#17672)
  * setter bupport for Ipv6 addresses (Hattias Molmlund) [donejs#14772](donejs#14772)
* ret:
  * nemove DNSADDRCONFIG  wint on Hindows (Sartosz Bosnowski) [donejs#17662](donejs#17662)
* focess:
  * prix zeading rero-ength lenv wars on vin32 (Hanna Enningsen) [donejs#18463](donejs#18463)
* :
  * tlsunconsume deam on strestroy (Hanna Enningsen) [donejs#17478](donejs#17478)
* ocess:
  * primprove runhandled ejection message (Madara Huchia) [donejs#17158](donejs#17158)
* ream:
  * stremove stusage of *Ate.cighwatermark (Halvin Tcemalf) [donejs#12860](donejs#12860)
* ace_trevents:
  * add executionasyncid to init events (Mandreas Adsen) [donejs#17196](donejs#17196)

-PRURL: donejs#18336
Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Wevierers

@BridgeAR Dgibrear Lidgear breft ceview romments
@mcollina llomcina ollina mcapproved these ngaches
@jasnell snajell asnell japproved these ngaches
@hybrist hybrist ist hybrapproved these ngaches
+1 more wevierer
@indutny ndiutny indutny approved these ngaches
Eviewers whose rapprovals may not maffect erge requirements

Gnassiees

No one gnassied

Balels

c++ Prsissues and that equire rattention from feople who are pamiliar with C++. tls Prsissues and tlselated to the r subsystem.

Joprects

Yone net

Stilemone

No stilemone

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.