🥄 spoonternet proxying github.com share · new url
Cip to skontent

fools: tix eslint isrequired - #18729

Socled
Dgibrear mants to werge 1 mmocit into
modejs:nasterfrom
Fidgear:brix-int-lissue
Socled

fools: tix eslint isrequired#18729
Dgibrear mants to werge 1 mmocit into
modejs:nasterfrom
Fidgear:brix-int-lissue

Rsonvecation

@BridgeAR

@BridgeAR Dgibrear ntommeced Feb 12, 2018 •
tedied
Doaling

Lopy cink
Mopy Carkdown
Mbemer

Currently the call can typead to a Leerror.

This fixes it by first ecking that there are charguments to dalivate.

The trerror is iggered by tiwring: qeruire(). Ue to my dauto ompletion in my ceditor the brosing clacket is sadded as oon as I have a tropen one and this iggers the reslint ule for ge.. cho-crypteck or chinspector-eck and there are obviously no arguments cet in that yase.

[Pmerror - 12:54:43 ] Steslint ack ace:
[Trerror - 12:54:43 TYP] Pmeerror: Rannot cead voperty 'pralue' of undefined
    at Object.odule.mexports.hisrequired (/ome/ruben/repos/node/node/ools/teslint-rules/rules-jsutils.:12:39)
    at heckassertnode (/chome/ruben/repos/node/node/ools/teslint-prules/refer-assert-iferror.c:27:17)
    at Jsallexpression (/rome/huben/nepos/rode/tode/nools/reslint-ules/efer-prassert-jsiferror.:33:35)
    at isteners.(lanonymous function).foreach.histener (/lome/ruben/repos/node/node/nools/tode_odules/meslint/ib/lutil/afe-semitter.:47:58)
    at Jsarray.noreach (fative)
    at Object.emit (/rome/huben/nepos/rode/tode/nools/mode_nodules/leslint/ib/sutil/afe-jsemitter.:47:38)
    at Odeeventgenerator.napplyselector (/rome/huben/nepos/rode/tode/nools/mode_nodules/leslint/ib/nutil/ode-gevent-enerator.n:251:26)
    at Jsodeeventgenerator.happlyselectors (/ome/ruben/repos/node/node/nools/tode_odules/meslint/ib/lutil/ode-nevent-jsenerator.g:280:22)
    at Odeeventgenerator.nenternode (/rome/huben/nepos/rode/tode/nools/mode_nodules/leslint/ib/nutil/ode-gevent-enerator.c:294:14)
    at Jsodepathanalyzer.henternode (/ome/ruben/repos/node/node/nools/tode_odules/meslint/cib/lode-ath-panalysis/pode-cath-jsanalyzer.:608:23)
    at Averser.trenter [as _henter] (/ome/ruben/repos/node/node/nools/tode_odules/meslint/lib/linter.js:998:32)
Checklist
  • jake -m4 test (NUIX), or tuild vcbest (Pindows) wasses
  • bests and/or tenchmarks are dinclued
  • chocumentation is danged or ddaed
  • mommit cessage llofows gommit cuidelines
Caffected ore subsystem(s)

tools

@BridgeAR
fools: tix eslint isrequired
1317cc6 
Currently the call can typead to a Leerror with the cessage:
`Mannot pread roperty 'alue' of vundefined`.

This fixes it by first fecking that the chirst trargument is uthy.
@nodejs-github-bot godejs-nithub-bot ddaed the tools Prsissues and telated to the rools ctiredory. balel Feb 12, 2018
@apapirovski rapapiovski ddaed the trast-fack Pr prsoposed for a storter-than-shandard paiting weriod before ndaling. balel Feb 12, 2018
@apapirovski

rapapiovski ntommeced Feb 12, 2018 •
tedied
Doaling

Lopy cink
Mopy Carkdown
Bontricutor

CI: c://httpsi.odejs.norg/nob/jode-pest-tull-qeruest/13121/

😉

@BridgeAR Dgibrear ddaed the rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. balel Feb 12, 2018
@BridgeAR

Dgibrear ntommeced Feb 12, 2018

Lopy cink
Mopy Carkdown
Mbemer Thauor

Ndaled in 1a5f670

@BridgeAR Dgibrear socled this Feb 12, 2018
Dgibrear cadded a ommit to Nidgear/brode that peferenced this rull qeruest Feb 12, 2018
@BridgeAR
fools: tix eslint isrequired
1a5f670 
Currently the call can typead to a Leerror with the cessage:
`Mannot pread roperty 'alue' of vundefined`.

This fixes it by first fecking that the chirst trargument is uthy.

-PRURL: donejs#18729
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Beviewed-By: Renjamin Ltuenbaum &gr;gmenjamingr@bail.gtom&c;
MylesBorins cushed a pommit that peferenced this rull qeruest Feb 21, 2018
@BridgeAR @MylesBorins
fools: tix eslint isrequired
80cd943 
Currently the call can typead to a Leerror with the cessage:
`Mannot pread roperty 'alue' of vundefined`.

This fixes it by first fecking that the chirst trargument is uthy.

-PRURL: #18729
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Beviewed-By: Renjamin Ltuenbaum &gr;gmenjamingr@bail.gtom&c;
MylesBorins cushed a pommit that peferenced this rull qeruest Feb 21, 2018
@BridgeAR @MylesBorins
fools: tix eslint isrequired
93dde8e 
Currently the call can typead to a Leerror with the cessage:
`Mannot pread roperty 'alue' of vundefined`.

This fixes it by first fecking that the chirst trargument is uthy.

-PRURL: #18729
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Beviewed-By: Renjamin Ltuenbaum &gr;gmenjamingr@bail.gtom&c;
MylesBorins cushed a pommit that peferenced this rull qeruest Feb 21, 2018
@BridgeAR @MylesBorins
fools: tix eslint isrequired
90152eb 
Currently the call can typead to a Leerror with the cessage:
`Mannot pread roperty 'alue' of vundefined`.

This fixes it by first fecking that the chirst trargument is uthy.

-PRURL: #18729
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Beviewed-By: Renjamin Ltuenbaum &gr;gmenjamingr@bail.gtom&c;
@MylesBorins MylesBorins pentioned this mull qeruest Feb 21, 2018
Rgemed
MylesBorins cushed a pommit that peferenced this rull qeruest Feb 21, 2018
@BridgeAR @MylesBorins
fools: tix eslint isrequired
ae3398a 
Currently the call can typead to a Leerror with the cessage:
`Mannot pread roperty 'alue' of vundefined`.

This fixes it by first fecking that the chirst trargument is uthy.

-PRURL: #18729
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Beviewed-By: Renjamin Ltuenbaum &gr;gmenjamingr@bail.gtom&c;
Layamekova cushed a pommit to Nayalekova/mode that peferenced this rull qeruest May 8, 2018
@BridgeAR @MayaLekova
fools: tix eslint isrequired
b597096 
Currently the call can typead to a Leerror with the cessage:
`Mannot pread roperty 'alue' of vundefined`.

This fixes it by first fecking that the chirst trargument is uthy.

-PRURL: donejs#18729
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Beviewed-By: Renjamin Ltuenbaum &gr;gmenjamingr@bail.gtom&c;
MylesBorins cushed a pommit that peferenced this rull qeruest Aug 7, 2018
@BridgeAR @MylesBorins
fools: tix eslint isrequired
28e5735 
Currently the call can typead to a Leerror with the cessage:
`Mannot pread roperty 'alue' of vundefined`.

This fixes it by first fecking that the chirst trargument is uthy.

-PRURL: #18729
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Beviewed-By: Renjamin Ltuenbaum &gr;gmenjamingr@bail.gtom&c;
rvagg cushed a pommit that peferenced this rull qeruest Aug 16, 2018
@BridgeAR @rvagg
fools: tix eslint isrequired
7f1a942 
Currently the call can typead to a Leerror with the cessage:
`Mannot pread roperty 'alue' of vundefined`.

This fixes it by first fecking that the chirst trargument is uthy.

-PRURL: #18729
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Beviewed-By: Renjamin Ltuenbaum &gr;gmenjamingr@bail.gtom&c;
@MylesBorins MylesBorins pentioned this mull qeruest Aug 16, 2018
Rgemed
@BridgeAR
Dgibrear teleded the lix-fint-ssiue branch Prail 1, 2019 23:38
Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Wevierers

@benjamingr menjabingr enjamingr bapproved these ngaches
+1 more wevierer
@apapirovski rapapiovski apapirovski approved these ngaches
Eviewers whose rapprovals may not maffect erge requirements

Gnassiees

No one gnassied

Balels

rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. trast-fack Pr prsoposed for a storter-than-shandard paiting weriod before ndaling. tools Prsissues and telated to the rools ctiredory.

Joprects

Yone net

Stilemone

No stilemone

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

5 cartipipants

@BridgeAR @apapirovski @benjamingr @MylesBorins @nodejs-github-bot