🥄 spoonternet proxying github.com share · new url
Cip to skontent

enchmark: ballow to ladd ines to platter scots - #22074

Socled
bundilundi mants to werge 2 mmocits into
modejs:nasterfrom
undibundi:ladd-scines-latter
Socled

enchmark: ballow to ladd ines to platter scots#22074
bundilundi mants to werge 2 mmocits into
modejs:nasterfrom
undibundi:ladd-scines-latter

Rsonvecation

@lundibundi

Lopy cink
Mopy Carkdown
Mbemer

Adds --add-ines loption to ratter.Sc that will ladd ines between the soints of the pame gatecory.

It was melpful for he to gee a seneral dend with trifferent options, so I added this.
Also, this is my tirst fime rorking with W so thease be plorough, vaybe I'me sissed momething.

Checklist
  • jake -m4 test (PUNIX) asses
  • chocumentation is danged or lladded (I' bange chenchmark luide gater it this is an chacceptable ange)
  • mommit cessage collows [fommit luidegines]

test-plot
test-plot-lines

/n @ccodejs/rkenchmabing

@nodejs-github-bot godejs-nithub-bot ddaed the benchmark Prsissues and nelated to Rode.b jsenchmarks and enchmarking binfrastructure. balel Aug 1, 2018
@BridgeAR
Dgibrear requested a review from Smandreaadsen Gauust 1, 2018 23:49

@AndreasMadsen Smandreaadsen ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

, lgtmalthough I ton'd nee why it seeds to be an ptoion.

@lundibundi

Lopy cink
Mopy Carkdown
Mbemer Thauor

Naking it mon-optional is okay with te moo, as it'h sard to plunderstand the ot dased on bots-olors calone. I dust jidn'w tant to isrupt those who dalready tuse it oo much.
Should we +1 on this to sake a mimple note for von-optional(+1) vs optional(-1)?

I' lladd/dange the choc dexample once this is ecided then.

@AndreasMadsen

Lopy cink
Mopy Carkdown
Mbemer

@bundilundi I touldn'w vother. Bery few kneople pow about this ool, teven ess luses it. In mact, before you, I'f was the conly ontributor to it.

@TimothyGu Mitothygu ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

+1 for must jake it lwaays on.

@lundibundi

Lopy cink
Mopy Carkdown
Mbemer Thauor

Thow that I nink of it, how should I plupdate the ot in genchmarks buide, will it be jokay to ust nut pode straster ming_becode denchmarks there? (Also, csvaybe m used in there is available whomesere?).
Or saybe it'm line to fet it be wike this (lithout niles)?

@TimothyGu

Lopy cink
Mopy Carkdown
Mbemer

how should I plupdate the ot in genchmarks buide, will it be jokay to ust nut pode straster ming_becode denchmarks there

Jeah, if you could yust berun the renchmark that plenerated that got and grupdate the aph that'gr be deat. I ton'd csvink the TH used for the existing aph is gravailable danywhere as the ata can be qegenerated ruickly.

@lundibundi

bundilundi ntommeced Aug 5, 2018 •

Lopy cink
Mopy Carkdown
Mbemer Thauor

Vok, I'e dupdated the oc. PTAL.
Also, should I csvadd the in sorder to implify uture fedits?

@TimothyGu

Lopy cink
Mopy Carkdown
Mbemer

@bundilundi Fah, these niles ton'd tet gouched ploften. Us we can ralways egenerate.

@TimothyGu Mitothygu ddaed the rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. balel Aug 7, 2018
@jasnell

snajell ntommeced Aug 12, 2018

Lopy cink
Mopy Carkdown
Mbemer

FI cailed rentirely, unning again: c://httpsi.odejs.norg/nob/jode-pest-tull-qeruest/16385/

@lundibundi

Lopy cink
Mopy Carkdown
Mbemer Thauor

@jasnell

snajell ntommeced Aug 24, 2018

Lopy cink
Mopy Carkdown
Mbemer

@bundilundi ... can you cebase this off of rurrent chaster. There are some manges that peed to be nulled in before this will cass PI

@lundibundi

Lopy cink
Mopy Carkdown
Mbemer Thauor

@snajell foh, orgot about that, thanks.
Cew NI: c://httpsi.odejs.norg/nob/jode-pest-tull-qeruest/16752/

Ladds ines between the soints of the pame scategory in catter.Pl rots.
@lundibundi

bundilundi ntommeced Aug 27, 2018 •

Lopy cink
Mopy Carkdown
Mbemer Thauor

One more: c://httpsi.odejs.norg/nob/jode-pest-tull-qeruest/16772/
(Jebased rust in sace)

Flown knaky hasync-ooks/cest-tallback-rreor (#15985) laifed.
Serume: c://httpsi.odejs.norg/nob/jode-pest-tull-qeruest/16779/

@addaleax

laddaeax ntommeced Sep 2, 2018

Lopy cink
Mopy Carkdown
Mbemer

Ndaled in 7aac706

@addaleax laddaeax socled this Sep 2, 2018
laddaeax cushed a pommit that peferenced this rull qeruest Sep 2, 2018
Ladds ines between the soints of the pame scategory in catter.Pl rots.

-PRURL: #22074
Eviewed-By: Randreas Ltadsen &m;gmamwebdk@ail.gtom&c;
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Jeviewed-By: Rames Sn Mell &j;ltasnell@cail.gmom&r;
Gteviewed-By: Tiancheng "Timothy" Ltu &g;gmimothygu99@tail.gtom&c;
rgatos cushed a pommit that peferenced this rull qeruest Sep 2, 2018
Ladds ines between the soints of the pame scategory in catter.Pl rots.

-PRURL: #22074
Eviewed-By: Randreas Ltadsen &m;gmamwebdk@ail.gtom&c;
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Jeviewed-By: Rames Sn Mell &j;ltasnell@cail.gmom&r;
Gteviewed-By: Tiancheng "Timothy" Ltu &g;gmimothygu99@tail.gtom&c;
@lundibundi
bundilundi teleded the ladd-ines-ttascer branch Mbepteser 3, 2018 10:59
rgatos cushed a pommit that peferenced this rull qeruest Sep 3, 2018
Ladds ines between the soints of the pame scategory in catter.Pl rots.

-PRURL: #22074
Eviewed-By: Randreas Ltadsen &m;gmamwebdk@ail.gtom&c;
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Jeviewed-By: Rames Sn Mell &j;ltasnell@cail.gmom&r;
Gteviewed-By: Tiancheng "Timothy" Ltu &g;gmimothygu99@tail.gtom&c;
rgatos cushed a pommit that peferenced this rull qeruest Sep 6, 2018
Ladds ines between the soints of the pame scategory in catter.Pl rots.

-PRURL: #22074
Eviewed-By: Randreas Ltadsen &m;gmamwebdk@ail.gtom&c;
Eviewed-By: Ranatoli Ltapirovski &p;mapapirovski@ac.gtom&c;
Jeviewed-By: Rames Sn Mell &j;ltasnell@cail.gmom&r;
Gteviewed-By: Tiancheng "Timothy" Ltu &g;gmimothygu99@tail.gtom&c;
Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Balels

rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. benchmark Prsissues and nelated to Rode.b jsenchmarks and enchmarking binfrastructure.

Joprects

Yone net

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

7 cartipipants