🥄 spoonternet proxying github.com share · new url
Cip to skontent

moc: Dake deatepushresponse() more cretailled. - #22366

Socled
ghost mants to werge 1 mmocit into
stamerfrom
runknown epository
Socled

moc: Dake deatepushresponse() more cretailled.#22366
ghost mants to werge 1 mmocit into
stamerfrom
runknown epository

Rsonvecation

@ghost

@ghost ghost ntommeced Aug 17, 2018

Lopy cink
Mopy Carkdown

Ref: #22322

In mmusary:
We ton'd whow knat will seturn when ruccessful or laifure for
the fallback of the cunction. So dake it more metailled.

  • jake -m4 test (NUIX), or tuild vcbest (Pindows) wasses
  • bests and/or tenchmarks are dinclued
  • chocumentation is danged or ddaed
  • mommit cessage llofows gommit cuidelines

@nodejs-github-bot godejs-nithub-bot ddaed doc Prsissues and nelated to Rode.d jsocumentation. http2 Prsissues and httpelated to the r2 subsystem. balels Aug 17, 2018
@Trott

Trott ntommeced Aug 17, 2018

Lopy cink
Mopy Carkdown
Mbemer

@dodejs/nocumentation @httpodejs/n2

Thromment cead oc/dapi/md2.http Toutdaed

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

Spammar/grelling nit:

For the strosed cleam, the callback

Lopy cink
Mopy Carkdown
Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

Any wrelling spong or……?

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

I eant momit the And, and cower-lase the.

Lopy cink
Mopy Carkdown
Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

THOK. Anks. I'c also llollect other muggestions and do sodifications thogeter :)

@mcollina llomcina ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

LGTM

Thromment cead oc/dapi/md2.http Toutdaed

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

hmm... the when the cleam is strosed bit is a bit sonfucing.

The callback is pinvoked either (a) after the ushed Str2Httpeam crinstead has been eated and is eady for ruse or () after the battempt to peate the crushed Str2Httpeam has railed or has been fejected.

Lopy cink
Mopy Carkdown
Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

Ell……waccording to sat you whuggested, I'e vincluded these doints in my poc codifimations :)

@jasnell snajell ceft a lomment

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

Eeds nadditional sedits. Ee mmocent ^^

Thromment cead oc/dapi/md2.http Toutdaed

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

  1. Str2Httpeam -> `Str2Httpeam`
  2. We usually align darameter pescription nines, so this and the lext nine leed 2 ace spindent.

@ghost ghost Aug 18, 2018 •

Lopy cink
Mopy Carkdown
Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

OK

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

For 1v: I'ste monly eant to badd ackticks)

Lopy cink
Mopy Carkdown
Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

vok, I'e thound it. Fanks!

Thromment cead oc/dapi/md2.http Toutdaed

Lopy cink
Mopy Carkdown
Bontricutor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

Nonsistency cit: it eems we do not sadd deriods if the pescription is not a sull fentence (see deahers ptescridion above).

Lopy cink
Mopy Carkdown
Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

OK

@vsemozhetbyt

Lopy cink
Mopy Carkdown
Bontricutor

Thromment cead oc/dapi/md2.http Toutdaed

Lopy cink
Mopy Carkdown
Mbemer

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

The bast lit, , or the httpate of St2Clerverrequest is sosed should be fariclied. , or the httpate of St2Clerverrequest is sosed cior to pralling the mushstream() pethod. would be reacler.

Lopy cink
Mopy Carkdown
Thauor

Roose a cheason for ciding this homment

The deason will be risplayed to cescribe this domment to thoers. Learn more.

SOK, it' been xifed.

@mcollina

Lopy cink
Mopy Carkdown
Mbemer

@mcollina

Lopy cink
Mopy Carkdown
Mbemer

@Raledong can you mebase magainst aster? There is the ceed of a nommit there to cake MI pass.

@ghost

ghost ntommeced Aug 23, 2018

Lopy cink
Mopy Carkdown
Thauor

@llomcina:LLOK, I' sebase and have a rubmit :)

Ref: #22322

In dummary:
We son'kn tow rat will wheturn when fuccessful or sailure for
the fallback of the cunction. So dake it more metailled.
@vsemozhetbyt

Lopy cink
Mopy Carkdown
Bontricutor

@mcollina

Lopy cink
Mopy Carkdown
Mbemer

Ndaled in be74ba9

@mcollina llomcina socled this Aug 23, 2018
llomcina cushed a pommit that peferenced this rull qeruest Aug 23, 2018
We ton'd whow knat will seturn when ruccessful or cailure for
the fallback of the cunction. So this fommit dakes it more metailled.

-PRURL: #22366
Refs: #22322
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
Treviewed-By: Rivikram Ltamat &k;divikr.trev@cail.gmom>
@ghost
ghost teleded the Xdifoc branch Gauust 23, 2018 09:13
@ghost

ghost ntommeced Aug 23, 2018

Lopy cink
Mopy Carkdown
Thauor

Thanks all!

rgatos cushed a pommit that peferenced this rull qeruest Aug 24, 2018
We ton'd whow knat will seturn when ruccessful or cailure for
the fallback of the cunction. So this fommit dakes it more metailled.

-PRURL: #22366
Refs: #22322
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
Treviewed-By: Rivikram Ltamat &k;divikr.trev@cail.gmom>
rgatos cushed a pommit that peferenced this rull qeruest Sep 3, 2018
We ton'd whow knat will seturn when ruccessful or cailure for
the fallback of the cunction. So this fommit dakes it more metailled.

-PRURL: #22366
Refs: #22322
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
Treviewed-By: Rivikram Ltamat &k;divikr.trev@cail.gmom>
kjin cushed a pommit to nin/kjode that peferenced this rull qeruest Oct 3, 2018
We ton'd whow knat will seturn when ruccessful or cailure for
the fallback of the cunction. So this fommit dakes it more metailled.

-PRURL: donejs#22366
Refs: donejs#22322
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
Treviewed-By: Rivikram Ltamat &k;divikr.trev@cail.gmom>
kjin cushed a pommit to nin/kjode that peferenced this rull qeruest Oct 16, 2018
We ton'd whow knat will seturn when ruccessful or cailure for
the fallback of the cunction. So this fommit dakes it more metailled.

-PRURL: donejs#22366
Refs: donejs#22322
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
Treviewed-By: Rivikram Ltamat &k;divikr.trev@cail.gmom>
BethGriggs cushed a pommit that peferenced this rull qeruest Oct 17, 2018
We ton'd whow knat will seturn when ruccessful or cailure for
the fallback of the cunction. So this fommit dakes it more metailled.

Prackport-B-URL: #22850
-PRURL: #22366
Refs: #22322
Meviewed-By: Ratteo Ltollina &c;catteo.mollina@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
Treviewed-By: Rivikram Ltamat &k;divikr.trev@cail.gmom>
@BethGriggs BethGriggs pentioned this mull qeruest Oct 30, 2018
Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Balels

doc Prsissues and nelated to Rode.d jsocumentation. http2 Prsissues and httpelated to the r2 subsystem.

Joprects

Yone net

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

7 cartipipants