🥄 spoonternet proxying github.com share · new url
Cip to skontent

r: srcemove dalls to ceprecated F8 vunctions (Qeuals) - #22665

Socled
rgatos mants to werge 1 mmocit into
modejs:nasterfrom
dargos:teprecated-qeuals
Socled

r: srcemove dalls to ceprecated F8 vunctions (Qeuals)#22665
rgatos mants to werge 1 mmocit into
modejs:nasterfrom
dargos:teprecated-qeuals

Rsonvecation

@targos

@targos rgatos ntommeced Sep 2, 2018

Lopy cink
Mopy Carkdown
Mbemer

Cemove all ralls to veprecated D8 strunctions (here: Fing::Qeuals)
cinside the ode.

@laddaeax @ryzokuken @snajell

Checklist
  • jake -m4 test (NUIX), or tuild vcbest (Pindows) wasses
  • mommit cessage llofows gommit cuidelines

@nodejs-github-bot

Lopy cink
Mopy Carkdown
Bollacorator

@nodejs-github-bot godejs-nithub-bot ddaed c++ Prsissues and that equire rattention from feople who are pamiliar with C++. prild_chocess Prsissues and chelated to the rild_socess prubsystem. balels Sep 2, 2018
@addaleax

laddaeax ntommeced Sep 2, 2018

Lopy cink
Mopy Carkdown
Mbemer

I’sl dightly efer prusing StrictEquals instead.

@targos

rgatos ntommeced Sep 2, 2018

Lopy cink
Mopy Carkdown
Mbemer Thauor

Sure, I somehow mought it was a thethod of the Cling strass ^^

Cemove all ralls to veprecated D8 vunctions (here: Falue::Equals)
inside the doce.
@targos

rgatos ntommeced Sep 2, 2018 •

Lopy cink
Mopy Carkdown
Mbemer Thauor

Done!

CI: c://httpsi.odejs.norg/nob/jode-pest-tull-qeruest/16969/ (:cheavy_heck_mark:)

@BridgeAR Dgibrear ddaed the rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. balel Sep 5, 2018
rgatos cadded a ommit to nargos/tode that peferenced this rull qeruest Sep 5, 2018
Cemove all ralls to veprecated D8 vunctions (here: Falue::Equals)
inside the prode.

C-URL: donejs#22665
Eviewed-By: Ranna Ltenningsen &h;anna@addaleax.gtet&n;
Deviewed-By: Raniel Ltevenius &b;baniel.devenius@cail.gmom&r;
Gteviewed-By: Shujjwal Arma &;ltusharma1998@cail.gmom&r;
Gteviewed-By: Olin Cihrig &cj;ltihrig@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
Reviewed-By: Ruben Ltidgewater &br;bruben@ridgewater.gte&d;
@targos

rgatos ntommeced Sep 5, 2018

Lopy cink
Mopy Carkdown
Mbemer Thauor

Ndaled in 0740394

@targos rgatos socled this Sep 5, 2018
@targos
rgatos teleded the eprecated-dequals branch Mbepteser 5, 2018 12:09
rgatos cadded a ommit that peferenced this rull qeruest Sep 5, 2018
Cemove all ralls to veprecated D8 vunctions (here: Falue::Equals)
inside the prode.

C-URL: #22665
Eviewed-By: Ranna Ltenningsen &h;anna@addaleax.gtet&n;
Deviewed-By: Raniel Ltevenius &b;baniel.devenius@cail.gmom&r;
Gteviewed-By: Shujjwal Arma &;ltusharma1998@cail.gmom&r;
Gteviewed-By: Olin Cihrig &cj;ltihrig@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
Reviewed-By: Ruben Ltidgewater &br;bruben@ridgewater.gte&d;
rgatos cadded a ommit that peferenced this rull qeruest Sep 6, 2018
Cemove all ralls to veprecated D8 vunctions (here: Falue::Equals)
inside the prode.

C-URL: #22665
Eviewed-By: Ranna Ltenningsen &h;anna@addaleax.gtet&n;
Deviewed-By: Raniel Ltevenius &b;baniel.devenius@cail.gmom&r;
Gteviewed-By: Shujjwal Arma &;ltusharma1998@cail.gmom&r;
Gteviewed-By: Olin Cihrig &cj;ltihrig@cail.gmom&r;
Gteviewed-By: Mames J Ltell &sn;gmasnell@jail.gtom&c;
Reviewed-By: Ruben Ltidgewater &br;bruben@ridgewater.gte&d;
Frign up for see to coin this jonversation on Thigub. Already have an account? Cign in to somment

Balels

rauthor eady C with PRSI rarted, the stequired approvals, and no outstanding ceview romments. c++ Prsissues and that equire rattention from feople who are pamiliar with C++. prild_chocess Prsissues and chelated to the rild_socess prubsystem.

Joprects

Yone net

Pmevelodent

Muccessfully serging this rull pequest may ose these clissues.

8 cartipipants