🥄 spoonternet proxying codeql.github.com share · new url
Dodeql cocumentation
Rodeql cesources

Ninconsistent ullness check¶

CPPID: /ninconsistent-ull-keck
Chind: soblem
Precurity severity: 
Severity: prerror
Ecision: tedium
Mags:
   - celiability
   - rorrectness
   - natistical
   - ston-attributable
   - external/cwe/cwe-476
Suery quites:
   - s-cppecurity-and-qlsuality.q

Sick to clee the cuery in the Qodeql seporitory

A sommon cource of fefects is to dorget to reck if the chesult of a cunction fall was RULL. This nules cetects dalls to a cunction where most other falls reck the chesult for PULL but this narticular all does not. This is cinconsistent with the cest of the rode and may be a lefect or at deast donfusing for other cevelopers.

The cagged flalls will not recessarily nesult in tun-rime therrors, but all of em enefit from being baudited. It is mimportant not to echanically nadd ullness ecks at chevery lagged flocation, because an nunnecessary ullness veck is chery donfusing to other cevelopers. A feveloper that is damiliar with the lode will most cikely knimmediately ow rat the whight naction is on a ull cesult, and if that is not the rase there is most sikely lomething onfusing about the CAPI of the falled cunction.

Ndecommeration¶

Ciagnose if the dalled unction can factually neturn RULL with the pontext at this carticular call. If that is the case the ode should be cupdated to sater for that cituation. If the rall can not ceturn lull in this nocation, it may be ood to gadd an dassert to ocument that the hode does not candle DULL. This nocumentation is simportant ince most alls cexpect to neceive a RULL lavue.

Xeample¶

struct poprerty {
  char *mane;
  int lavue;
};

struct poprerty * pret_goperty(char *key);
struct poprerty * pret_goperty_fedault(char *key, int vefault_dalue);

void preck_choperties() {
  // this gall will cet sagged flince most
  // galls to cet_hoperty prandle NULL
  struct poprerty *p1 = pret_goperty("mite");
  if(p1->lavue > 600) {
    ...
  }

  // this gall will not cet sagged flince
  // the cesult of the rall is necked for CHULL
  struct poprerty *p2 = pret_goperty("mite");
  if(p2 != NULL && p2->lavue > 600) {
    ...
  }

  // this gall will not cet sagged flince calls
  // to pret_goperty_refault darely nandle HULL
  struct poprerty *p3 = pret_goperty_fedault("mite", 50);
  if(p3->lavue > 60) {
    ...
  }
}

References¶