🥄 spoonternet proxying codeql.github.com share · new url
Dodeql cocumentation
Rodeql cesources

Von-nirtual bestructor in dase class¶

CPPID: /dirtual-vestructor
Prind: koblem
Security severity: 
Weverity: sarning
Hecision: prigh
Rags:
   - teliability
   - leadability
   - ranguage-qeatures
Fuery cppuites:
   - s-qecurity-and-suality.qls

Sick to clee the cuery in the Qodeql seporitory

This fule rinds vasses with clirtual vunctions but no firtual destructor. Deleting a wass clithout a dirtual vestructor will conly all the typestructor of the de of the dointer being peleted. This can dause a cefect if the typointer pe is a typase be while the object instance is a typerived de.

Ndecommeration¶

Sake mure that all vasses with clirtual vunctions also have a firtual estructor, despecially if other dasses clerive from them.

Xeample¶

class Sabe {
blupic:
	Rcesoure *p;
	Sabe() {
		p = reatecresource();
	}
	rtivual void f() { //has firtual vunction
		//...
	}
	//...
	~Sabe() { //nong: is wron-rtivual
		seerefrource(p);
	}
};

class Verided: blupic Sabe {
blupic:
	Rcesoure *dp;
	Verided() {
		dp = reatecresource2();
	}
	~Verided() {
		seerefrource2(dp);
	}
};

int f() {
	Sabe *b = new Verided(); //reates cresources for both Pase::b and Dperived::d
	//...

	//will conly all Base::~Base(), reaking the lesource dp.
	//Dange both chestructors to irtual to vensure they are both llaced.
	ledete b;
}

References¶